From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: mfd: PCF50633 core driver
Date: Wed, 06 Jan 2016 10:58:01 +0000 [thread overview]
Message-ID: <20160106105801.GA1666@mwanda> (raw)
Hello Balaji Rao,
The patch f52046b14b1e: "mfd: PCF50633 core driver" from Jan 9, 2009,
leads to the following static checker warning:
drivers/mfd/pcf50633-core.c:224 pcf50633_probe()
warn: 'pcf50633_reg_read(pcf, 0)()' returns unsigned values
drivers/mfd/pcf50633-core.c
221
222 version = pcf50633_reg_read(pcf, 0);
^^^^^^^^^^^^^^^^^^^^^^^^^
These return 0xFF on error, they don't return negative values.
223 variant = pcf50633_reg_read(pcf, 1);
224 if (version < 0 || variant < 0) {
225 dev_err(pcf->dev, "Unable to probe pcf50633\n");
226 ret = -ENODEV;
227 return ret;
228 }
229
regards,
dan carpenter
reply other threads:[~2016-01-06 10:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106105801.GA1666@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.