From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752406AbcAFPaN (ORCPT ); Wed, 6 Jan 2016 10:30:13 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:36790 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653AbcAFPaL (ORCPT ); Wed, 6 Jan 2016 10:30:11 -0500 Date: Wed, 6 Jan 2016 16:30:05 +0100 From: Peter Senna Tschudin To: Joe Perches Cc: thomas@winischhofer.net, gregkh@linuxfoundation.org, trivial@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] usb-misc: cleanup sisusbvga Message-ID: <20160106153005.GA3022@collabora.com> References: <1452012850-6990-1-git-send-email-peter.senna@collabora.com> <1452020004.4334.156.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452020004.4334.156.camel@perches.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2016 at 10:53:24AM -0800, Joe Perches wrote: > On Tue, 2016-01-05 at 17:54 +0100, Peter Senna Tschudin wrote: > [] > > Patch 1 is the biggest and fix only whitespace, tab and newline issues. I used > > > > $ git diff -w --word-diff=porcelain drivers/usb/misc/sisusbvga/sisusb.c > > > > to verify that this patch do not change any visible character. If the size of > > this patch is a problem, please let me know in how many patches to split it. > > Thanks. > > Maybe for future series, but not one in particular unless > you feel like respinning it: > > As porcelain is meant for script consumption, I think a good > mechanism > for human review is to separate patch 1 into 2 patches. > > 1: Only horizontal line whitespace changes > git diff -w shouldn't show any changes and > git blame -w would not show any change either. > 2: Only vertical line changes additions/reformatting > > This makes it easy to use git diff -w on patch 1 and > patch 2 can be more easily scanned visually. This makes sense, the challenge is doing horizontal first, as making vertical changes will probably require additional horizontal changes. Or is it ok to fix horizontal issues caused by vertical changes in the vertical changes patch? Is it reasonable to respin if other issues are reported for this series? Anyway I'll make the next series as you suggest. > > It's also nice to use objdiff and show no object changes. Nice tool. I didn't know about it. Should I create a README file for the scripts directory?