From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] memory: omap-gpmc: Add Kconfig option for debug Date: Wed, 6 Jan 2016 08:44:00 -0800 Message-ID: <20160106164400.GJ12777@atomide.com> References: <568662FC.9050206@gmail.com> <20160104170206.GC12777@atomide.com> <201601041834.56056@pali> <20160104174001.GD12777@atomide.com> <568AC0F9.2010304@gmail.com> <20160105041356.GE12777@atomide.com> <20160105084947.GG22661@pali> <20160105224929.GF12777@atomide.com> <568CD697.9060800@gmail.com> <20160106090543.GC11364@pali> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160106090543.GC11364@pali> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Nishanth Menon , Paul Walmsley , Ivaylo Dimitrov , Aaro Koskinen , Sebastian Reichel , pavel@ucw.cz, linux-omap@vger.kernel.org, Brian Hutchinson , linux-arm-kernel@lists.infradead.org, Roger Quadros List-Id: linux-omap@vger.kernel.org KiBQYWxpIFJvaMOhciA8cGFsaS5yb2hhckBnbWFpbC5jb20+IFsxNjAxMDYgMDE6MDZdOgo+IE9u IFdlZG5lc2RheSAwNiBKYW51YXJ5IDIwMTYgMTA6NTU6NTEgSXZheWxvIERpbWl0cm92IHdyb3Rl Ogo+ID4gT24gIDYuMDEuMjAxNiAwMDo0OSwgVG9ueSBMaW5kZ3JlbiB3cm90ZToKPiA+ID4KPiA+ ID5TdWdnZXN0ZWQgZml4IGJlbG93LCBwbGVhc2UgdGVzdCBhbmQgcmVwbHkgd2l0aCB5b3VyIFRl c3RlZC1ieSdzIGlmCj4gPiA+aXQgc29sdmVzIHRoZSBwcm9ibGVtIHNvIHdlIG1heSBzdGlsbCBi ZSBhYmxlIHRvIGdldCB0aGlzIGludG8gdjQuNC4KPiA+ID4KPiA+ID44PCAtLS0tLS0tLS0tLS0t LS0KPiA+ID5Gcm9tOiBUb255IExpbmRncmVuIDx0b255QGF0b21pZGUuY29tPgo+ID4gPkRhdGU6 IFR1ZSwgNSBKYW4gMjAxNiAxMjowNDoyMCAtMDgwMAo+ID4gPlN1YmplY3Q6IFtQQVRDSF0gQVJN OiBPTUFQMis6IEZpeCBvbmVuYW5kIHJhdGUgZGV0ZWN0aW9uIHRvIGF2b2lkIGZpbGVzeXN0ZW0K PiA+ID4gIGNvcnJ1cHRpb24KPiA+ID4KPiA+ID5Db21taXQgNjNhYTk0NWIxMDEzICgibWVtb3J5 OiBvbWFwLWdwbWM6IEFkZCBLY29uZmlnIG9wdGlvbiBmb3IgZGVidWciKQo+ID4gPnVuaWZpZWQg dGhlIEdQTUMgZGVidWcgZm9yIHRoZSBTb0NzIHdpdGggR1BNQy4gVGhlIGNvbW1pdCBhbHNvIGxl ZnQKPiA+ID5vdXQgdGhlIG9wdGlvbiBmb3IgSFdNT0RfSU5JVF9OT19SRVNFVCBhcyB3ZSBub3cg cmVxdWlyZSBwcm9wZXIgdGltaW5ncwo+ID4gPmZvciBHUE1DIHRvIGJlIGFibGUgdG8gcmVtYXAg R1BNQyBkZXZpY2VzIG91dCBvZiBhZGRyZXNzIDAuCj4gPiA+Cj4gPiA+VW5mb3J0dW5hdGVseSBv biA5MDAsIG9uZW5hbmQgbm93IG9ubHkgcGFydGlhbGx5IHdvcmtzIHdpdGggdGhlIGRldmljZQo+ ID4gPnRyZWUgcHJvdmlkZWQgdGltaW5ncy4gSXQgd29ya3MgZW5vdWdoIHRvIGdldCBkZXRlY3Rl ZCBidXQgdGhlIGNsb2NrCj4gPiA+cmF0ZSBzdXBwb3J0ZWQgYnkgdGhlIG9uZW5hbmQgY2hpcCBn ZXRzIG1pc2RldGVjdGVkLiBUaGlzIGluIHR1cm4gY2F1c2VzCj4gPiA+dGhlIEdQTUMgdGltaW5n cyB0byBiZSBtaXNjYWxjdWxhdGVkIGFuZCB0aGlzIGxlYWRzIGludG8gZmlsZSBzeXN0ZW0KPiA+ ID5jb3JydXB0aW9uIG9uIG45MDAuCj4gPiA+Cj4gPiA+TG9va3MgbGlrZSBvbmVuYW5kIG5lZWRz IENTX0NPTkZJRzEgYml0IDI3IFdSSVRFVFlQRSBzZXQgZm9yIGZvciBzeW5jCj4gPiA+d3JpdGUu IFRoaXMgaXMgbmVlZGVkIGFsc28gZm9yIGFzeW5jIHRpbWluZ3Mgd2hlbiB3ZSB3cml0ZSB0byBv bmVuYW5kCj4gPiA+d2l0aCBvbWFwMl9vbmVuYW5kX3NldF9hc3luY19tb2RlKCkuIFdpdGhvdXQg c3luYyB3cml0ZSBiaXQgc2V0LCB0aGUKPiA+ID5hc3luYyByZWFkIGZvciB0aGUgb25lbmFuZCBP TkVOQU5EX1JFR19WRVJTSU9OX0lEIHdpbGwgcmV0dXJuIDB4ZmZmLgo+ID4gPgo+ID4gPkxldCdz IGV4aXQgd2l0aCBhbiBlcnJvciBpZiBvbmVuYW5kIHJhdGUgaXMgbm90IGRldGVjdGVkLiBBbmQg bGV0J3MKPiA+ID5yZW1vdmUgdGhlIGV4dHJhIGNhbGwgdG8gb21hcDJfb25lbmFuZF9zZXRfYXN5 bmNfbW9kZSgpIGFzIHdlIG9ubHkKPiA+ID5uZWVkIHRvIGRvIHRoaXMgb25jZSBhdCB0aGUgZW5k IG9mIG9tYXAyX29uZW5hbmRfc2V0dXBfYXN5bmMoKS4KPiA+ID4KPiA+ID5SZXBvcnRlZC1ieTog SXZheWxvIERpbWl0cm92IDxpdm8uZy5kaW1pdHJvdi43NUBnbWFpbC5jb20+Cj4gPiA+U2lnbmVk LW9mZi1ieTogVG9ueSBMaW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNvbT4KPiA+ID4KPiA+ID4tLS0g YS9hcmNoL2FybS9tYWNoLW9tYXAyL2dwbWMtb25lbmFuZC5jCj4gPiA+KysrIGIvYXJjaC9hcm0v bWFjaC1vbWFwMi9ncG1jLW9uZW5hbmQuYwo+ID4gCj4gPiBCZWxsb3cgaXMgZ3BtYyBkbWVzZyBv dXRwdXQgd2l0aCB0aGF0IGZpeC4gSSBhbHNvIGRpc2FibGVkCj4gPiBDT05GSUdfT01BUF9HUE1D X0RFQlVHIGFuZCBhbSBzdGlsbCBhYmxlIHRvIGJvb3QgdG8gbWFlbW8gd2l0aCBubyBvYnZpb3Vz Cj4gPiBwcm9ibGVtcy4KPiA+IAo+ID4gU28sIHNlZW1zIHRoYXQgZml4ZXMgdGhlIHByb2JsZW0s IGZlZWwgZnJlZSB0byAgYWRkOgo+ID4gCj4gPiBUZXN0ZWQtYnk6IEl2YXlsbyBEaW1pdHJvdiA8 aXZvLmcuZGltaXRyb3YuNzVAZ21haWwuY29tPgo+IAo+IEdyZWF0ISBUaGFuayB5b3UgZm9yIGZp eGluZyBhbmQgdGVzdGluZyB0aGlzIHByb2JsZW0hCgpHb29kIHRvIGhlYXIgaXQgZml4ZXMgdGhl IGlzc3VlLiBJJ2xsIHdhaXQgdG8gaGVhciBmcm9tIEFhcm8gYmVmb3JlCmNvbW1pdHRpbmcuCgpS ZWdhcmRzLAoKVG9ueQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 6 Jan 2016 08:44:00 -0800 Subject: [PATCH 2/2] memory: omap-gpmc: Add Kconfig option for debug In-Reply-To: <20160106090543.GC11364@pali> References: <568662FC.9050206@gmail.com> <20160104170206.GC12777@atomide.com> <201601041834.56056@pali> <20160104174001.GD12777@atomide.com> <568AC0F9.2010304@gmail.com> <20160105041356.GE12777@atomide.com> <20160105084947.GG22661@pali> <20160105224929.GF12777@atomide.com> <568CD697.9060800@gmail.com> <20160106090543.GC11364@pali> Message-ID: <20160106164400.GJ12777@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Pali Roh?r [160106 01:06]: > On Wednesday 06 January 2016 10:55:51 Ivaylo Dimitrov wrote: > > On 6.01.2016 00:49, Tony Lindgren wrote: > > > > > >Suggested fix below, please test and reply with your Tested-by's if > > >it solves the problem so we may still be able to get this into v4.4. > > > > > >8< --------------- > > >From: Tony Lindgren > > >Date: Tue, 5 Jan 2016 12:04:20 -0800 > > >Subject: [PATCH] ARM: OMAP2+: Fix onenand rate detection to avoid filesystem > > > corruption > > > > > >Commit 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug") > > >unified the GPMC debug for the SoCs with GPMC. The commit also left > > >out the option for HWMOD_INIT_NO_RESET as we now require proper timings > > >for GPMC to be able to remap GPMC devices out of address 0. > > > > > >Unfortunately on 900, onenand now only partially works with the device > > >tree provided timings. It works enough to get detected but the clock > > >rate supported by the onenand chip gets misdetected. This in turn causes > > >the GPMC timings to be miscalculated and this leads into file system > > >corruption on n900. > > > > > >Looks like onenand needs CS_CONFIG1 bit 27 WRITETYPE set for for sync > > >write. This is needed also for async timings when we write to onenand > > >with omap2_onenand_set_async_mode(). Without sync write bit set, the > > >async read for the onenand ONENAND_REG_VERSION_ID will return 0xfff. > > > > > >Let's exit with an error if onenand rate is not detected. And let's > > >remove the extra call to omap2_onenand_set_async_mode() as we only > > >need to do this once at the end of omap2_onenand_setup_async(). > > > > > >Reported-by: Ivaylo Dimitrov > > >Signed-off-by: Tony Lindgren > > > > > >--- a/arch/arm/mach-omap2/gpmc-onenand.c > > >+++ b/arch/arm/mach-omap2/gpmc-onenand.c > > > > Bellow is gpmc dmesg output with that fix. I also disabled > > CONFIG_OMAP_GPMC_DEBUG and am still able to boot to maemo with no obvious > > problems. > > > > So, seems that fixes the problem, feel free to add: > > > > Tested-by: Ivaylo Dimitrov > > Great! Thank you for fixing and testing this problem! Good to hear it fixes the issue. I'll wait to hear from Aaro before committing. Regards, Tony