From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752147AbcAFUxf (ORCPT ); Wed, 6 Jan 2016 15:53:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42067 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708AbcAFUxb (ORCPT ); Wed, 6 Jan 2016 15:53:31 -0500 Date: Wed, 6 Jan 2016 18:53:27 -0200 From: Arnaldo Carvalho de Melo To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com, kan.liang@intel.com, jolsa@kernel.org Subject: Re: [PATCH] perf pmu: fix alias->snapshot missing initialization bug Message-ID: <20160106205327.GD2503@redhat.com> References: <1452106201-13073-1-git-send-email-eranian@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452106201-13073-1-git-send-email-eranian@google.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jan 06, 2016 at 07:50:01PM +0100, Stephane Eranian escreveu: > This patch fixes a bug in __perf_pmu__new_alias() whereby > the alias->snapshot field was not initialized to false. This > led to random alias->snapshot value for an alias and > was breaking some measurements such as: > > $ perf stat -a -e uncore_imc/data_reads/ -I 1000 sleep 100 > > Because the event ended up being treated as snapshot mode, when > it is not. Thanks, applied. - Arnaldo