From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 07/16] usb: ehci-ci: Add missing registers.
Date: Wed, 6 Jan 2016 21:53:54 +0100 [thread overview]
Message-ID: <201601062153.55090.marex@denx.de> (raw)
In-Reply-To: <1452104488-5502-8-git-send-email-mateusz.kulikowski@gmail.com>
On Wednesday, January 06, 2016 at 07:21:19 PM, Mateusz Kulikowski wrote:
> Some registers of usb_ehci were marked as reserved.
> This may be true for some variants of Chipidea USB core, but they have
> meaning on other devices.
>
> The following registers were added:
> sbusstatus/sbusmode: AHB-related registers
> genconfig*: Auxiluary IP core configuration registers.
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> ---
CCing Fabio, so he can check this on the NXP chips :)
In general, I am not opposed to this change.
Reviewed-by: Marek Vasut <marex@denx.de>
> Changes in v1: New patch
>
> include/usb/ehci-ci.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/usb/ehci-ci.h b/include/usb/ehci-ci.h
> index 725aec5..305b180 100644
> --- a/include/usb/ehci-ci.h
> +++ b/include/usb/ehci-ci.h
> @@ -191,7 +191,11 @@ struct usb_ehci {
> u32 gptimer1_ld; /* 0x088 - General Purpose Timer 1 load value */
> u32 gptimer1_ctrl; /* 0x08C - General Purpose Timer 1 control */
> u32 sbuscfg; /* 0x090 - System Bus Interface Control */
> - u8 res2[0x6C];
> + u32 sbusstatus; /* 0x094 - System Bus Interface Status */
> + u32 sbusmode; /* 0x098 - System Bus Interface Mode */
> + u32 genconfig; /* 0x09C - USB Core Configuration */
> + u32 genconfig2; /* 0x0A0 - USB Core Configuration 2 */
> + u8 res2[0x5c];
> u8 caplength; /* 0x100 - Capability Register Length */
> u8 res3[0x1];
> u16 hciversion; /* 0x102 - Host Interface Version */
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-01-06 20:53 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 18:21 [U-Boot] [PATCH v1 00/16] Add support for 96boards Dragonboard410C board Mateusz Kulikowski
2016-01-06 18:21 ` [U-Boot] [PATCH v1 01/16] serial: Add support for Qualcomm serial port Mateusz Kulikowski
2016-01-11 16:57 ` Simon Glass
2016-01-06 18:21 ` [U-Boot] [PATCH v1 02/16] gpio: Add support for Qualcomm gpio controller Mateusz Kulikowski
2016-01-11 16:57 ` Simon Glass
2016-01-11 21:27 ` Mateusz Kulikowski
2016-01-06 18:21 ` [U-Boot] [PATCH v1 03/16] mmc: Add support for Qualcomm SDHCI controller Mateusz Kulikowski
2016-01-11 16:57 ` Simon Glass
2016-01-06 18:21 ` [U-Boot] [PATCH v1 04/16] ehci-hcd: Add init_after_reset Mateusz Kulikowski
2016-01-11 16:57 ` Simon Glass
2016-01-06 18:21 ` [U-Boot] [PATCH v1 05/16] usb: ulpi: Add Kconfig options for ULPI Mateusz Kulikowski
2016-01-06 20:49 ` Marek Vasut
2016-01-07 22:12 ` Mateusz Kulikowski
2016-01-07 22:50 ` Marek Vasut
2016-01-07 23:18 ` Simon Glass
2016-01-11 21:30 ` Mateusz Kulikowski
2016-01-06 18:21 ` [U-Boot] [PATCH v1 06/16] usb: Rename ehci-fsl.h to ehci-ci.h Mateusz Kulikowski
2016-01-06 20:51 ` Marek Vasut
2016-01-06 18:21 ` [U-Boot] [PATCH v1 07/16] usb: ehci-ci: Add missing registers Mateusz Kulikowski
2016-01-06 20:53 ` Marek Vasut [this message]
2016-01-06 18:21 ` [U-Boot] [PATCH v1 08/16] ehci-ci.h: drop generic USBCMD fields Mateusz Kulikowski
2016-01-06 20:54 ` Marek Vasut
2016-01-06 18:21 ` [U-Boot] [PATCH v1 09/16] ehci: Add support for Qualcomm EHCI Mateusz Kulikowski
2016-01-06 21:04 ` Marek Vasut
2016-01-11 21:39 ` Mateusz Kulikowski
2016-01-11 22:02 ` Marek Vasut
2016-01-06 18:21 ` [U-Boot] [PATCH v1 10/16] drivers: Add SPMI bus uclass Mateusz Kulikowski
2016-01-11 16:57 ` Simon Glass
2016-01-11 21:41 ` Mateusz Kulikowski
2016-01-06 18:21 ` [U-Boot] [PATCH v1 11/16] spmi: Add sandbox test driver Mateusz Kulikowski
2016-01-11 16:57 ` Simon Glass
2016-01-06 18:21 ` [U-Boot] [PATCH v1 12/16] drivers: spmi: Add support for Qualcomm SPMI bus driver Mateusz Kulikowski
2016-01-11 16:57 ` Simon Glass
2016-01-06 18:21 ` [U-Boot] [PATCH v1 13/16] pmic: Add support for Qualcomm PM8916 PMIC Mateusz Kulikowski
2016-01-11 16:58 ` Simon Glass
2016-01-06 18:21 ` [U-Boot] [PATCH v1 14/16] gpio: Add support for Qualcomm PM8916 gpios Mateusz Kulikowski
2016-01-11 16:58 ` Simon Glass
2016-01-06 18:21 ` [U-Boot] [PATCH v1 15/16] arm: Add support for Qualcomm Snapdragon family Mateusz Kulikowski
2016-01-11 16:58 ` Simon Glass
2016-01-06 18:21 ` [U-Boot] [PATCH v1 16/16] board: Add Qualcomm Dragonboard 410C support Mateusz Kulikowski
2016-01-07 10:23 ` Sjoerd Simons
2016-01-11 21:49 ` Mateusz Kulikowski
2016-01-11 16:58 ` Simon Glass
2016-01-11 22:01 ` Mateusz Kulikowski
2016-01-13 20:32 ` Simon Glass
2016-01-20 21:46 ` Mateusz Kulikowski
2016-01-20 4:35 ` Simon Glass
2016-01-20 22:00 ` Mateusz Kulikowski
2016-01-20 23:49 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201601062153.55090.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.