From: Brian Norris <computersforpeace@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: "Boris Brezillon" <boris.brezillon@free-electrons.com>,
"Sørensen, Stefan" <Stefan.Sorensen@spectralink.com>,
"Heiko Schocher" <hs@denx.de>,
"Frans Klaver" <fransklaver@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-4.5 v2] mtd: nand: assign reasonable default name for NAND drivers
Date: Wed, 6 Jan 2016 14:53:36 -0800 [thread overview]
Message-ID: <20160106225336.GK109450@google.com> (raw)
In-Reply-To: <1452019185-134498-1-git-send-email-computersforpeace@gmail.com>
On Tue, Jan 05, 2016 at 10:39:45AM -0800, Brian Norris wrote:
> Commits such as commit 853f1c58c4b2 ("mtd: nand: omap2: show parent
> device structure in sysfs") attempt to rely on the core MTD code to set
> the MTD name based on the parent device. However, nand_base tries to set
> a different default name according to the flash name (e.g., extracted
> from the ONFI parameter page), which means NAND drivers will never make
> use of the MTD defaults. This is not the intention of commit
> 853f1c58c4b2.
>
> This results in problems when trying to use the cmdline partition
> parser, since the MTD name is different than expected. Let's fix this by
> providing a default NAND name, where possible.
>
> Note that this is not really a great default name in the long run, since
> this means that if there are multiple MTDs attached to the same
> controller device, they will have the same name. But that is an existing
> issue and requires future work on a better controller vs. flash chip
> abstraction to fix properly.
>
> Fixes: 853f1c58c4b2 ("mtd: nand: omap2: show parent device structure in sysfs")
> Reported-by: Heiko Schocher <hs@denx.de>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Tested-by: Heiko Schocher <hs@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Frans Klaver <fransklaver@gmail.com>
> Cc: <stable@vger.kernel.org>
> ---
> v2:
> * target 4.5, as 4.4 is getting late
> * add -stable tags
> * move assignment directly into nand_scan_ident() (nand_set_defaults() has a
> slightly different purpose and gets reused, so it's not as good of a
> candidate)
Applied to l2-mtd.git, for 4.5 (+ stable)
prev parent reply other threads:[~2016-01-06 22:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 18:39 [PATCH for-4.5 v2] mtd: nand: assign reasonable default name for NAND drivers Brian Norris
2016-01-06 22:53 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106225336.GK109450@google.com \
--to=computersforpeace@gmail.com \
--cc=Stefan.Sorensen@spectralink.com \
--cc=boris.brezillon@free-electrons.com \
--cc=fransklaver@gmail.com \
--cc=hs@denx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.