From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH v3 3/5] perf tools: Fix dynamic sort keys to sort properly
Date: Wed, 6 Jan 2016 20:50:45 -0300 [thread overview]
Message-ID: <20160106235045.GF2012@kernel.org> (raw)
In-Reply-To: <20160106233149.GE2012@kernel.org>
Em Wed, Jan 06, 2016 at 08:31:49PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Jan 07, 2016 at 08:26:45AM +0900, Namhyung Kim escreveu:
> > On Wed, Jan 06, 2016 at 08:06:43PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Wed, Jan 06, 2016 at 09:54:59AM +0900, Namhyung Kim escreveu:
> > > > Currently, the dynamic sort keys compares trace data using memcmp().
> > > > But for output sorting, it should check data size and compare by word.
> > > > Also it sorted strings in reverse order, fix it.
> > >
> > > Can this be broken down in two patches? This is complex code, lets try
> > > to make it as bisectable as possible.
> >
> > OK, I'll break out the string part then. But I think it doesn't help
> > much to reduce the complexity.
>
> Well, number of patches is not a problem, everytime I see a "Also lets
> do this other thing" I cringe, it is automatic, sorry :-\
>
> For reviewing its soooo much better to see things nicely separated, and
> sometimes I like one part but not the other, so I pick one and continue
> discussion on the other, etc.
Ah, please rebase from my latest perf/core, I'm still holding on it
since some 'perf test' entries are failing and I want to check first if
its due to bugs introduced in this branch...
- Arnaldo
next prev parent reply other threads:[~2016-01-06 23:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 0:54 [PATCH v3 1/5] perf tools: Add all matching dynamic sort keys for field name Namhyung Kim
2016-01-06 0:54 ` [PATCH v3 2/5] perf tools: Add document for dynamic sort keys Namhyung Kim
2016-01-06 0:54 ` [PATCH v3 3/5] perf tools: Fix dynamic sort keys to sort properly Namhyung Kim
2016-01-06 23:06 ` Arnaldo Carvalho de Melo
2016-01-06 23:26 ` Namhyung Kim
2016-01-06 23:31 ` Arnaldo Carvalho de Melo
2016-01-06 23:43 ` Namhyung Kim
2016-01-06 23:50 ` Arnaldo Carvalho de Melo [this message]
2016-01-07 0:07 ` Namhyung Kim
2016-01-06 0:55 ` [PATCH v3 4/5] perf tools: Support dynamic sort keys for -F/--fields Namhyung Kim
2016-01-06 0:55 ` [PATCH v3 5/5] perf evlist: Add --trace-fields option to show trace fields Namhyung Kim
2016-01-06 23:10 ` Arnaldo Carvalho de Melo
2016-01-06 23:21 ` Namhyung Kim
2016-01-06 23:29 ` Arnaldo Carvalho de Melo
2016-01-06 23:42 ` Namhyung Kim
2016-01-06 11:19 ` [PATCH v3 1/5] perf tools: Add all matching dynamic sort keys for field name Jiri Olsa
2016-01-06 16:29 ` Arnaldo Carvalho de Melo
2016-01-06 23:09 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106235045.GF2012@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.