From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Kubecek Subject: Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode Date: Thu, 7 Jan 2016 08:59:52 +0100 Message-ID: <20160107075951.GD27753@unicorn.suse.cz> References: <87618083B2453E4A8714035B62D6799250504549@FMSMSX105.amr.corp.intel.com> <1452147313-22886-1-git-send-email-zyjzyj2000@gmail.com> <20160107065340.GB27753@unicorn.suse.cz> <568E15B6.8010301@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: emil.s.tantilov@intel.com, jay.vosburgh@canonical.com, vfalico@gmail.com, gospo@cumulusnetworks.com, netdev@vger.kernel.org, boris.shteinbock@windriver.com To: zhuyj Return-path: Received: from mx2.suse.de ([195.135.220.15]:41138 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbcAGH7z (ORCPT ); Thu, 7 Jan 2016 02:59:55 -0500 Content-Disposition: inline In-Reply-To: <568E15B6.8010301@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jan 07, 2016 at 03:37:26PM +0800, zhuyj wrote: > >If I read this right, whenever this state (link up but speed/duplex > >unknown) is entered, you'll keep writing this message into kernel log > >every miimon milliseconds until something changes. I'm not sure how long > >a NIC can stay in such state but it might get quite annoying (even more > >if something really goes wrong and NIC stays that way which can't be > >completely ruled out, IMHO). > > Sure, Thanks a lot. I want to confirm link_up without link_speed. It > is not usual. So I think this only lasts for several seconds. > It is very important to us since it can help us to find the root cause. For debugging purposes it's fine, of course. But this looked like an officially submitted patch so I didn't like the idea of log spamming (even one second could result in 10-100 messages and admins certainly would hate that). Michal Kubecek