From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 09/12] virtio: vfio: Enable
 RTE_PCI_DRV_NEED_MAPPING flag in driver
Date: Thu, 7 Jan 2016 10:20:58 -0800
Message-ID: <20160107102058.43499eae@xeon-e3>
References: <1452184390-5994-1-git-send-email-sshukla@mvista.com>
 <1452184390-5994-10-git-send-email-sshukla@mvista.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Santosh Shukla <sshukla@mvista.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com
 [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id 446BB9224
 for <dev@dpdk.org>; Thu,  7 Jan 2016 19:20:52 +0100 (CET)
Received: by mail-pa0-f44.google.com with SMTP id ho8so3745807pac.2
 for <dev@dpdk.org>; Thu, 07 Jan 2016 10:20:52 -0800 (PST)
In-Reply-To: <1452184390-5994-10-git-send-email-sshukla@mvista.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu,  7 Jan 2016 22:03:06 +0530
Santosh Shukla <sshukla@mvista.com> wrote:

> +#ifdef RTE_EAL_VFIO
> +		.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_DETACHABLE,
> +#else
>  		.drv_flags = RTE_PCI_DRV_DETACHABLE,
> +#endif

Since VFIO is determined at runtime not compile time, the flags should
be updated at runtime not compile time.