From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH v2 4/6] perf/amd/iommu: Introduce data structure for tracking prev count. Date: Thu, 7 Jan 2016 13:27:00 +0100 Message-ID: <20160107122700.GF19149@8bytes.org> References: <1451672020-2150-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1451672020-2150-5-git-send-email-Suravee.Suthikulpanit@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1451672020-2150-5-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Suravee Suthikulpanit Cc: peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Fri, Jan 01, 2016 at 12:13:38PM -0600, Suravee Suthikulpanit wrote: > To enable AMD IOMMU PMU to support multiple IOMMUs, this patch introduces > a new data structure, perf_amd_iommu.prev_cnts, to track previous counts > of IOMMU performance counters in multi-IOMMU environment. > > Also, this patch allocates perf_iommu_cnts for internal use > when manages counters. >>From this commit message I don't really get what perf_amd_iommu.prev_cnts and perf_iommu_cnts will be used for. Can you please add this to the message? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752997AbcAGM1F (ORCPT ); Thu, 7 Jan 2016 07:27:05 -0500 Received: from 8bytes.org ([81.169.241.247]:50668 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752254AbcAGM1D (ORCPT ); Thu, 7 Jan 2016 07:27:03 -0500 Date: Thu, 7 Jan 2016 13:27:00 +0100 From: Joerg Roedel To: Suravee Suthikulpanit Cc: bp@alien8.de, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH v2 4/6] perf/amd/iommu: Introduce data structure for tracking prev count. Message-ID: <20160107122700.GF19149@8bytes.org> References: <1451672020-2150-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1451672020-2150-5-git-send-email-Suravee.Suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451672020-2150-5-git-send-email-Suravee.Suthikulpanit@amd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 01, 2016 at 12:13:38PM -0600, Suravee Suthikulpanit wrote: > To enable AMD IOMMU PMU to support multiple IOMMUs, this patch introduces > a new data structure, perf_amd_iommu.prev_cnts, to track previous counts > of IOMMU performance counters in multi-IOMMU environment. > > Also, this patch allocates perf_iommu_cnts for internal use > when manages counters. >>From this commit message I don't really get what perf_amd_iommu.prev_cnts and perf_iommu_cnts will be used for. Can you please add this to the message?