All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-media@vger.kernel.org
Cc: "Daniel Glöckner" <daniel-gl@gmx.net>
Subject: [bug report] bt8xx/bttv-cards: module_param issue
Date: Thu, 7 Jan 2016 17:56:55 +0300	[thread overview]
Message-ID: <20160107145655.GA15551@mwanda> (raw)

I was looking at typos in MODULE_PARM_DESC() and I noticed a problem in
drivers/media/pci/bt8xx/bttv-cards.c

MODULE_PARM_DESC(saa6588, "if 1, then load the saa6588 RDS module, default (0) is to use the card definition.");

The saa6588[] array is not set up as a module parameter so you can't
actually use this setting.  I don't know if it's better to delete it or
enable it.

regards,
dan carpenter

                 reply	other threads:[~2016-01-07 14:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160107145655.GA15551@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=daniel-gl@gmx.net \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.