From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752973AbcAGPT3 (ORCPT ); Thu, 7 Jan 2016 10:19:29 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:39128 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752739AbcAGPT2 (ORCPT ); Thu, 7 Jan 2016 10:19:28 -0500 Date: Thu, 7 Jan 2016 16:19:18 +0100 From: Peter Senna Tschudin To: Sergei Shtylyov , Joe Perches Cc: thomas@winischhofer.net, gregkh@linuxfoundation.org, trivial@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Senna Tschudin Subject: Re: [PATCH 4/5] usb-misc: sisusbvga: Remove kmalloc logs and fix error path Message-ID: <20160107151918.GC4144@collabora.com> References: <1452012850-6990-1-git-send-email-peter.senna@collabora.com> <1452012850-6990-5-git-send-email-peter.senna@collabora.com> <568D5CD9.70704@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <568D5CD9.70704@cogentembedded.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 06, 2016 at 09:28:41PM +0300, Sergei Shtylyov wrote: > Hello. > > On 1/5/2016 7:54 PM, Peter Senna Tschudin wrote: > > >From: Peter Senna Tschudin > > > >This patch remove four calls to dev_err() from sisusb_probe() as > >reporting memory allocation failures is redundant: > > > > - Remove a call to dev_err() that was reporting unsuccesful call to > > kzalloc(). > > > > - Remove two calls to dev_err() that were reporting unsuccesful calls > > to kmalloc(). > > > > - Remove a call to dev_err() that was reporting unsuccesful call to > > kmalloc(), and replace it by code that clean up previously allocated > > resources and abort the probe with -ENOMEM. Before this modification > > sisusb->SiS_Pr could be dereferenced even it was null. > > I think the bug fix should be in its own patch. Don't intermix fixes with > cleanups please. Ok, I'll resend the series with the following changes: - split patch 1: vertical and horizontal changes - split patch 4: cleanups and fix