From: Benjamin LaHaise <bcrl@kvack.org>
To: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
Dmitry Monakhov <dmonakhov@openvz.org>
Subject: Re: [PATCH] aio: Fix freeze protection of aio writes
Date: Thu, 7 Jan 2016 11:24:10 -0500 [thread overview]
Message-ID: <20160107162409.GN4439@kvack.org> (raw)
In-Reply-To: <20160107151552.GA9828@quack.suse.cz>
On Thu, Jan 07, 2016 at 04:15:52PM +0100, Jan Kara wrote:
> On Thu 07-01-16 10:07:05, Benjamin LaHaise wrote:
...
> > Why isn't this code placed in file_start_write() and file_end_write()?
> > That makes more sense to me than sprinkling it in the aio code.
>
> Well, that would completely defeat the purpose of lockdep annotations for
> fs freeze protection - we want lockdep to treat file_start_write() -
> file_end_write() pair as a lock-unlock pair. But in case of AIO the unlock
> will happen from a different process than lock and lockdep cannot handle
> such cases. That's why for AIO we have to add some lockdep magic to avoid
> false warnings.
Okay, makes sense. Applied. I'll forward that with the other fix that
is pending.
-ben
--
"Thought is the essence of where you are now."
next prev parent reply other threads:[~2016-01-07 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 15:03 [PATCH] aio: Fix freeze protection of aio writes Jan Kara
2016-01-07 15:07 ` Benjamin LaHaise
2016-01-07 15:08 ` Benjamin LaHaise
2016-01-07 15:15 ` Jan Kara
2016-01-07 16:24 ` Benjamin LaHaise [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-11-26 17:10 Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107162409.GN4439@kvack.org \
--to=bcrl@kvack.org \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.