From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Cleaning up DDI translation tables
Date: Thu, 7 Jan 2016 18:37:26 +0200 [thread overview]
Message-ID: <20160107163726.GJ4437@intel.com> (raw)
In-Reply-To: <1452021535-22641-1-git-send-email-rodrigo.vivi@intel.com>
On Tue, Jan 05, 2016 at 11:18:55AM -0800, Rodrigo Vivi wrote:
> No functional changes.
>
> That state the obvious and just duplicate the place we
> need to change whenever the table is updated. So let's clean it.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index bc8a497..d3611f5 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -133,12 +133,12 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
> { 0x00002016, 0x000000A0, 0x0 },
> { 0x00005012, 0x0000009B, 0x0 },
> { 0x00007011, 0x00000088, 0x0 },
> - { 0x80009010, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> + { 0x80009010, 0x000000C0, 0x1 },
> { 0x00002016, 0x0000009B, 0x0 },
> { 0x00005012, 0x00000088, 0x0 },
> - { 0x80007011, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> + { 0x80007011, 0x000000C0, 0x1 },
> { 0x00002016, 0x000000DF, 0x0 },
> - { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> + { 0x80005012, 0x000000C0, 0x1 },
> };
>
> /* Skylake U */
> @@ -146,12 +146,12 @@ static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
> { 0x0000201B, 0x000000A2, 0x0 },
> { 0x00005012, 0x00000088, 0x0 },
> { 0x80007011, 0x000000CD, 0x0 },
> - { 0x80009010, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> + { 0x80009010, 0x000000C0, 0x1 },
> { 0x0000201B, 0x0000009D, 0x0 },
> - { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> - { 0x80007011, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> + { 0x80005012, 0x000000C0, 0x1 },
> + { 0x80007011, 0x000000C0, 0x1 },
> { 0x00002016, 0x00000088, 0x0 },
> - { 0x80005012, 0x000000C0, 0x1 }, /* Uses I_boost level 0x1 */
> + { 0x80005012, 0x000000C0, 0x1 },
> };
>
> /* Skylake Y */
> @@ -159,12 +159,12 @@ static const struct ddi_buf_trans skl_y_ddi_translations_dp[] = {
> { 0x00000018, 0x000000A2, 0x0 },
> { 0x00005012, 0x00000088, 0x0 },
> { 0x80007011, 0x000000CD, 0x0 },
> - { 0x80009010, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3 */
> + { 0x80009010, 0x000000C0, 0x3 },
> { 0x00000018, 0x0000009D, 0x0 },
> - { 0x80005012, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3 */
> - { 0x80007011, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3 */
> + { 0x80005012, 0x000000C0, 0x3 },
> + { 0x80007011, 0x000000C0, 0x3 },
> { 0x00000018, 0x00000088, 0x0 },
> - { 0x80005012, 0x000000C0, 0x3 }, /* Uses I_boost level 0x3 */
> + { 0x80005012, 0x000000C0, 0x3 },
> };
>
> /*
> --
> 2.4.3
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-01-07 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 19:18 [PATCH] drm/i915: Cleaning up DDI translation tables Rodrigo Vivi
2016-01-06 11:30 ` ✗ failure: Fi.CI.BAT Patchwork
2016-01-07 16:37 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107163726.GJ4437@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.