From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752465AbcAGR37 (ORCPT ); Thu, 7 Jan 2016 12:29:59 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37342 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752293AbcAGR36 (ORCPT ); Thu, 7 Jan 2016 12:29:58 -0500 Date: Thu, 7 Jan 2016 09:29:57 -0800 From: Greg KH To: Babu Moger Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers Message-ID: <20160107172957.GA29783@kroah.com> References: <1452187407-34440-1-git-send-email-babu.moger@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452187407-34440-1-git-send-email-babu.moger@oracle.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 07, 2016 at 09:23:27AM -0800, Babu Moger wrote: > I have never seen auto handoff working on TI and RENESAS cards. > Eventually, we force handoff. This code forces the handoff > unconditionally. It saves 5 seconds boot time for each card. > > Signed-off-by: Babu Moger > --- > drivers/usb/host/pci-quirks.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c > index f940056..b7ee895 100644 > --- a/drivers/usb/host/pci-quirks.c > +++ b/drivers/usb/host/pci-quirks.c > @@ -1003,6 +1003,13 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev) > ext_cap_offset = xhci_find_next_cap_offset(base, ext_cap_offset); > } while (1); > > + /* Auto handoff never worked for these devices. Force it and continue */ > + if (pdev->vendor == PCI_VENDOR_ID_TI || > + pdev->vendor == PCI_VENDOR_ID_RENESAS) { > + val = (val | XHCI_HC_OS_OWNED) & ~XHCI_HC_BIOS_OWNED; odd spaces here, why this format? And are you sure that all TI and Renesas host controllers have this issue? That's a very wide and broad test you are making here... thanks, greg k-h