From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: <linux-mtd@lists.infradead.org>,
Harvey Hunt <harvey.hunt@imgtec.com>,
Alex Smith <alex@alex-smith.me.uk>
Subject: Re: [PATCH] mtd: jz4780_nand: remove useless mtd->priv = chip assignment
Date: Thu, 7 Jan 2016 20:32:47 +0100 [thread overview]
Message-ID: <20160107203247.0a6fb5ed@bbrezillon> (raw)
In-Reply-To: <1452189779-20001-1-git-send-email-computersforpeace@gmail.com>
On Thu, 7 Jan 2016 10:02:59 -0800
Brian Norris <computersforpeace@gmail.com> wrote:
> As of commit 2d3b77bac34b ("mtd: nand: update mtd_to_nand()"), this
> assignment isn't necessary, since struct mtd_info is embedded in struct
> nand_chip.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Harvey Hunt <harvey.hunt@imgtec.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Alex Smith <alex@alex-smith.me.uk>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/nand/jz4780_nand.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/jz4780_nand.c b/drivers/mtd/nand/jz4780_nand.c
> index 17eb9f264187..6156c554e1c2 100644
> --- a/drivers/mtd/nand/jz4780_nand.c
> +++ b/drivers/mtd/nand/jz4780_nand.c
> @@ -270,7 +270,6 @@ static int jz4780_nand_init_chip(struct platform_device *pdev,
>
> chip = &nand->chip;
> mtd = nand_to_mtd(chip);
> - mtd->priv = chip;
> mtd->name = devm_kasprintf(dev, GFP_KERNEL, "%s.%d", dev_name(dev),
> cs->bank);
> if (!mtd->name)
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-07 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 18:02 [PATCH] mtd: jz4780_nand: remove useless mtd->priv = chip assignment Brian Norris
2016-01-07 19:32 ` Boris Brezillon [this message]
2016-01-07 20:27 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107203247.0a6fb5ed@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alex@alex-smith.me.uk \
--cc=computersforpeace@gmail.com \
--cc=harvey.hunt@imgtec.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.