Re: [PATCH] OMAP: Add keypad driver

[Tony Lindgren <tony@atomide.com>]

* Dmitry Torokhov <dmitry.torokhov@gmail.com> [160107 15:23]:
> On Thu, Jan 07, 2016 at 12:13:17PM -0800, Tony Lindgren wrote:
> > 
> > Sounds like the check is not needed if it has not been used for
> > past five years, so my preference is option #1 then.
> 
> OK, how about the below then?

Looks good to me thanks: Acked-by: Tony Lindgren <tony@atomide.com>

I've also corrected Aaro's email address, he may have some keyboard
input too.

Regards,

Tony


> Input: omap-keypad - remove dead check
> 
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Commit da1f026b532ce944d74461497dc6d8c16456466e ("Keyboard: omap-keypad:
> use matrix_keypad.h") switched the driver to use matrix keypad
> infrastructure, which made array of keycodes to be unsigned short, and
> caused the test for negativity never trigger. This leads to the following
> static checker warning:
> 
> 	drivers/input/keyboard/omap-keypad.c:158 omap_kp_tasklet()
> 	warn: 'keycodes[]' is never negative.
> 
> Given that we did not care about this check for a few years already let's
> simply remove it.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/input/keyboard/omap-keypad.c |    8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/input/keyboard/omap-keypad.c b/drivers/input/keyboard/omap-keypad.c
> index 75ad666..e0d72c8 100644
> --- a/drivers/input/keyboard/omap-keypad.c
> +++ b/drivers/input/keyboard/omap-keypad.c
> @@ -155,14 +155,6 @@ static void omap_kp_tasklet(unsigned long data)
>  			       "pressed" : "released");
>  #else
>  			key = keycodes[MATRIX_SCAN_CODE(row, col, row_shift)];
> -			if (key < 0) {
> -				printk(KERN_WARNING
> -				      "omap-keypad: Spurious key event %d-%d\n",
> -				       col, row);
> -				/* We scan again after a couple of seconds */
> -				spurious = 1;
> -				continue;
> -			}
>  
>  			if (!(kp_cur_group == (key & GROUP_MASK) ||
>  			      kp_cur_group == -1))