Re: 答复: 答复: [PATCH 3/3 nf-next] netfilter: nf_ct_helper: Add nf_conntrack_helpers_register()

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Jan 08, 2016 at 08:18:02AM +0800, Feng Gao wrote:
> Hi Pablo,
> 
> I know how to enhance it now, and it must be converted.
> Because there is one bug in the codes when using
> nf_conntrack_helpers_register.
> 
> Take the following codes as an example
>     for (i = 0; i < ports_c; i++) {
>         nf_ct_helper_init(&ftp[i][0], AF_INET, IPPROTO_TCP, "ftp",
>                   FTP_PORT, ports[i], &ftp_exp_policy, 0,
>                   sizeof(struct nf_ct_ftp_master), help,
>                   nf_ct_ftp_from_nlattr, THIS_MODULE);
>         nf_ct_helper_init(&ftp[i][1], AF_INET6, IPPROTO_TCP, "ftp",
>                   FTP_PORT, ports[i], &ftp_exp_policy, 0,
>                   sizeof(struct nf_ct_ftp_master), help,
>                   nf_ct_ftp_from_nlattr, THIS_MODULE);
>     }   
>     ret = nf_conntrack_helpers_register(&ftp[0][0], ports_c * 2);
> 
> When init the helper, we initialized the ftp[i][0], ftp[i][1], they are not
> continuous.
> So it bring one bug when use nf_conntrack_helpers_register(&ftp[0][0],
> ports_c * 2);
> 
> I will fix it later

Then, I going to keep these patchset back in this round, sorry.

Please, take over my 2/3 and 3/3 iteration, fix them and resubmit.

Thanks.