From: Rob Herring <robh@kernel.org>
To: Zhao Qiang <qiang.zhao@nxp.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Priyanka.Jain@freescale.com,
oss@buserror.net
Subject: Re: [PATCH 2/6] QE: Add ucc hdlc document to bindings
Date: Fri, 8 Jan 2016 14:10:17 -0600 [thread overview]
Message-ID: <20160108201017.GA26581@rob-hp-laptop> (raw)
In-Reply-To: <1452219494-31947-2-git-send-email-qiang.zhao@nxp.com>
On Fri, Jan 08, 2016 at 10:18:10AM +0800, Zhao Qiang wrote:
> Add ucc hdlc document to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> .../bindings/powerpc/fsl/cpm_qe/network.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
> index 29b28b8..017cbf7 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
> @@ -41,3 +41,38 @@ Example:
> fsl,mdio-pin = <12>;
> fsl,mdc-pin = <13>;
> };
> +
> +* HDLC
> +
> +Currently defined compatibles:
> +- fsl,ucc_hdlc
Don't use _.
> +
> +Properties for fsl,ucc_hdlc:
> +rx-clock-name : which clock QE use for RX
> +tx-clock-name : which clock QE use for TX
> +fsl,rx-sync-clock : which pin QE use for RX sync
> +fsl,tx-sync-clock : which pin QE use for TX sync
> +fsl,tx-timeslot : tx timeslot
> +fsl,rx-timeslot : rx timeslot
> +fsl,tdm-framer-type : tdm framer type
> +fsl,tdm-mode : tdm mode, normal or internal-loopback
> +fsl,tdm-id : tdm ID
> +fsl,siram-entry-id : SI RAM entry ID for the TDM
> +fsl,tdm-interface : hdlc based on tdm-interface
It is not clear what any of these properties do. For example, what are
allowed/valid values. Provide enough information to validate the
example.
Rob
> +
> +Example:
> +
> + ucc@2000 {
> + compatible = "fsl,ucc_hdlc";
> + rx-clock-name = "clk8";
> + tx-clock-name = "clk9";
> + fsl,rx-sync-clock = "rsync_pin";
> + fsl,tx-sync-clock = "tsync_pin";
> + fsl,tx-timeslot = <0xfffffffe>;
> + fsl,rx-timeslot = <0xfffffffe>;
> + fsl,tdm-framer-type = "e1";
> + fsl,tdm-mode = "normal";
> + fsl,tdm-id = <0>;
> + fsl,siram-entry-id = <0>;
> + fsl,tdm-interface;
> + };
> --
> 2.1.0.27.g96db324
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-08 20:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 2:18 [PATCH 1/6] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
2016-01-08 2:18 ` Zhao Qiang
2016-01-08 2:18 ` [PATCH 2/6] QE: Add ucc hdlc document to bindings Zhao Qiang
2016-01-08 2:18 ` Zhao Qiang
2016-01-08 20:10 ` Rob Herring [this message]
2016-01-08 2:18 ` [PATCH 3/6] QE: Add uqe_serial " Zhao Qiang
2016-01-08 2:18 ` Zhao Qiang
2016-01-08 20:12 ` Rob Herring
2016-01-11 8:19 ` Qiang Zhao
2016-01-11 8:19 ` Qiang Zhao
2016-01-11 8:19 ` Qiang Zhao
2016-01-18 3:28 ` Qiang Zhao
2016-01-18 3:28 ` Qiang Zhao
2016-01-18 9:10 ` Li Yang
2016-01-18 9:10 ` Li Yang
2016-01-18 9:24 ` Qiang Zhao
2016-01-18 9:24 ` Qiang Zhao
2016-01-18 9:24 ` Qiang Zhao
2016-01-18 23:07 ` Scott Wood
2016-01-18 23:07 ` Scott Wood
2016-01-19 1:22 ` Qiang Zhao
2016-01-19 1:22 ` Qiang Zhao
2016-01-19 1:22 ` Qiang Zhao
2016-01-08 2:18 ` [PATCH 4/6] T104xD4RDB: Add qe node to t104xd4rdb Zhao Qiang
2016-01-08 2:18 ` Zhao Qiang
2016-01-08 2:18 ` [PATCH 5/6] T104xRDB: Add qe node to t104xrdb Zhao Qiang
2016-01-08 2:18 ` Zhao Qiang
2016-01-08 2:18 ` [PATCH 6/6] T104xQDS: Add qe node to t104xqds Zhao Qiang
2016-01-08 2:18 ` Zhao Qiang
2016-01-08 21:02 ` [PATCH 1/6] QE: Add IC, SI and SIRAM document to device tree bindings Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108201017.GA26581@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Priyanka.Jain@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=qiang.zhao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.