From: Al Viro <viro@ZenIV.linux.org.uk>
To: Joshua Hudson <joshudson@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] add support for larger files in minix filesystem
Date: Sat, 9 Jan 2016 03:37:12 +0000 [thread overview]
Message-ID: <20160109033712.GA5955@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+jjjYSYafLBu+u6MNZG+0Tj=zgVmVVz-mTqwDgPq_-G3xChOQ@mail.gmail.com>
On Sun, Nov 01, 2015 at 07:56:36PM -0800, Joshua Hudson wrote:
> From: Joshua Hudson <joshudson@gmail.com>
>
> The Minix v3 filesystem and kernel driver have no actual dependency on files
> being less than 2GB in size; however the kernel does not allow creating a
> file of 2GB or larger on a Minix v3 filesystem. I was able to remove the pseudo-
> dependency easily by changing one line of code (filesystems need to tell VFS
> how big of files they allow).
Umm... AFAICS, native Minix v3 fsck will throw a fit if it sees anything
between 2Gb and 4Gb and truncate the value. Seeing that it's their
format _and_ silent changes like that (especially hidden by something like
"you need to binary-patch the field at this offset in superblock first")
are generally considered rude.
I'd suggest you to talk to Minix folks and convince them to raise that limit;
if it's merely a matter of unhappy fsck, it shouldn't be hard, but if their
minix/mfs/*.c code would get unhappy on files longer than 2Gb, it would be
harder and in that case we _really_ shouldn't run around creating such files
there.
Seriously, talk to Minix folks first.
next prev parent reply other threads:[~2016-01-09 3:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 3:56 [PATCH] add support for larger files in minix filesystem Joshua Hudson
2015-11-03 2:13 ` Joshua Hudson
2016-01-09 3:37 ` Al Viro [this message]
2016-01-09 18:45 ` Joshua Hudson
2016-01-09 21:37 ` One Thousand Gnomes
2016-01-09 23:11 ` Al Viro
2016-01-09 23:43 ` Joshua Hudson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160109033712.GA5955@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=joshudson@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.