From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753457AbcAIJ4U (ORCPT ); Sat, 9 Jan 2016 04:56:20 -0500 Received: from mail-pa0-f68.google.com ([209.85.220.68]:35610 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285AbcAIJ4Q (ORCPT ); Sat, 9 Jan 2016 04:56:16 -0500 Date: Sat, 9 Jan 2016 18:55:23 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Stephane Eranian , Andi Kleen , Masami Hiramatsu , Wang Nan Subject: Re: [RFC/PATCH v3] perf report: Show random usage tip on the help line Message-ID: <20160109095523.GC7818@danjae.kornet> References: <1452166913-27046-1-git-send-email-namhyung@kernel.org> <20160108075705.GA10894@gmail.com> <20160108125441.GE19314@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160108125441.GE19314@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 08, 2016 at 09:54:41AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jan 08, 2016 at 08:57:05AM +0100, Ingo Molnar escreveu: > > > > * Namhyung Kim wrote: > > > > > Currently perf report only shows a help message "For a higher level > > > overview, try: perf report --sort comm,dso" unconditionally (even if > > > the sort keys were used). Add more help tips and show randomly. > > > > > > Load tips from ${prefix}/share/doc/perf-tip/tips.txt file. > > > > > +++ b/tools/perf/Documentation/tips.txt > > > @@ -0,0 +1,14 @@ > > > +For a higher level overview, try: perf report --sort comm,dso > > > +Group related events with: perf record -e '{cycles,instructions}:S' > > > +Compare performance results with: perf diff [ ] > > > +Boolean options have negative forms like: perf report --no-children > > > +Customize output of perf script with: perf script -F event,ip,sym > > > +Generate a script for your data: perf script -g > > > +Save output of perf stat using: perf stat record > > > +Create archive of data to see it on other machine: perf archive > > > +Search options using a keyword: perf report -h > > > +Use parent filter to see specific call path: perf report -p > > > +listing interested events using substring match: perf list > > > +To see list of saved events and attributes: perf evlist -v > > > +Use --symfs if your symbol files are in non-standard location > > > +To see callchains in a more compact form: perf report -g folded > > > > Very nice! > > > > Acked-by: Ingo Molnar > > > > On top of this, what do you think about only doing a single tip per day, the 'tip > > of the day'? That would have two effects: > > > > - people who know all this already see this less > > > > - people who don't know all this will perhaps be more attentive, because a tip > > for every report is more likely to get ignored. > > > > This could be done via a flag in ~/.perf/ or so. > > > > Another suggestion: shouldn't the tips be tool specific, i.e. shouldn't there be a > > tip-report.txt, tip-record.txt, etc. set of files? > > Yeah, we could have per tool tip files, but then sometimes to use a > feature in 'report' we have to first use some magic combination on the > 'record' command line. Right. In addition, tips can depend on configurations, runtime environment and so on. But let's leave it as later work. :) > > Anyway, I think I'll apply Namhyung's latest, the one in this message, > and get the basic stuff in, we then go on improving on it. Agreed! Thanks, Namhyung