From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756486AbcAIQmg (ORCPT ); Sat, 9 Jan 2016 11:42:36 -0500 Received: from e32.co.us.ibm.com ([32.97.110.150]:58284 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755911AbcAIQmd (ORCPT ); Sat, 9 Jan 2016 11:42:33 -0500 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Sat, 9 Jan 2016 08:42:37 -0800 From: "Paul E. McKenney" To: nimisolo Cc: josh@joshtriplett.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rcu/tree: use true/false to set rdp->core_needs_qs Message-ID: <20160109164237.GG3818@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1452338584-3373-1-git-send-email-nimisolo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452338584-3373-1-git-send-email-nimisolo@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16010916-0005-0000-0000-00001B48CF4F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 09, 2016 at 06:23:04AM -0500, nimisolo wrote: > Maybe it's better to set rdp->core_needs_qs with true/false > > Signed-off-by: nimisolo Good catch, but someone beat you by about a month. To check for future changes, please see branch rcu/dev of: git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git Thanx, Paul > --- > kernel/rcu/tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index f07343b..0c0d09d 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -2377,7 +2377,7 @@ rcu_report_qs_rdp(int cpu, struct rcu_state *rsp, struct rcu_data *rdp) > if ((rnp->qsmask & mask) == 0) { > raw_spin_unlock_irqrestore(&rnp->lock, flags); > } else { > - rdp->core_needs_qs = 0; > + rdp->core_needs_qs = false; > > /* > * This GP can't end until cpu checks in, so all of our > -- > 2.5.0 >