From: Florian Westphal <fw@strlen.de>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: netdev@vger.kernel.org, jesse@kernel.org,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: Re: [PATCH net-next v4 05/10] fm10k: add rtnl lock protection in fm10k_io_resume
Date: Sat, 9 Jan 2016 22:51:09 +0100 [thread overview]
Message-ID: <20160109215109.GA16810@breakpoint.cc> (raw)
In-Reply-To: <1452352052-27574-6-git-send-email-hannes@stressinduktion.org>
Hannes Frederic Sowa <hannes@stressinduktion.org> wrote:
> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> index 4eb7a6fa6b0ddc..846d9b731c8c14 100644
> --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> @@ -2350,8 +2350,10 @@ static void fm10k_io_resume(struct pci_dev *pdev)
> /* reset clock */
> fm10k_ts_reset(interface);
>
> + rtnl_lock();
> if (netif_running(netdev))
> err = fm10k_open(netdev);
> + rtnl_lock();
Hmm. Looks like copy&paste error :)
next prev parent reply other threads:[~2016-01-09 21:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 15:07 [PATCH net-next v4 00/10] net: break dependency of drivers on geneve and vxlan Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 01/10] qlcnic: protect qlcnic_82xx_io_slot_reset with rtnl lock Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 02/10] mlx4: add rtnl lock protection in mlx4_en_restart Hannes Frederic Sowa
2016-01-11 12:12 ` Eugenia Emantayev
2016-01-09 15:07 ` [PATCH net-next v4 03/10] ixgbe: add rtnl locking in service task around vxlan_get_rx_port Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 04/10] benet: add rtnl lock protection around be_open in be_resume Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 05/10] fm10k: add rtnl lock protection in fm10k_io_resume Hannes Frederic Sowa
2016-01-09 21:51 ` Florian Westphal [this message]
2016-01-09 22:44 ` Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 06/10] netdev: add netdevice notifier type to trigger a reprogramming of offloads Hannes Frederic Sowa
2016-01-09 17:25 ` Tom Herbert
2016-01-09 17:30 ` Hannes Frederic Sowa
2016-01-09 22:27 ` Tom Herbert
2016-01-09 22:52 ` Hannes Frederic Sowa
[not found] ` <CALx6S341SP0XN-iBGeR_MXyu3LoYmXBsCBguDcwc26CVvF3Gtw@mail.gmail.com>
2016-01-11 12:11 ` Hannes Frederic Sowa
2016-01-11 16:09 ` Tom Herbert
2016-01-11 18:56 ` Hannes Frederic Sowa
2016-01-11 20:46 ` Tom Herbert
2016-01-11 21:09 ` Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 07/10] vxlan: break dependency to network drivers Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 08/10] geneve: " Hannes Frederic Sowa
2016-01-09 21:59 ` Jesse Gross
2016-01-09 15:07 ` [PATCH net-next v4 09/10] net: harmonize vxlan_get_rx_port and geneve_get_rx_port to netdev_refresh_offloads Hannes Frederic Sowa
2016-01-09 15:07 ` [PATCH net-next v4 10/10] netdev: update comments and explain idempotency and rtnl locking Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160109215109.GA16810@breakpoint.cc \
--to=fw@strlen.de \
--cc=hannes@stressinduktion.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.