All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfs: cancel COW in xfs_cancel_ioend
Date: Sun, 10 Jan 2016 08:54:09 +0100	[thread overview]
Message-ID: <20160110075409.GA8213@lst.de> (raw)
In-Reply-To: <20160109211713.GB6112@birch.djwong.org>

On Sat, Jan 09, 2016 at 01:17:13PM -0800, Darrick J. Wong wrote:
> > 
> > I've not seen the inode eviction asserts anymore, but I now hit a
> > corruption warnings in generic/168 reliably.  I did hit before as
> > well, but not very reliably.
> 
> I'll see if I can repro the 168 error; it's been running in a loop all
> night and hasn't bombed yet.

Note that this is over nfs to a local server, not running on xfs directly,
which is doing fine.

> In the meantime, I added some more tests and fixed a CoW corruption when an
> xfs_io_overwrite extent has cow reservations in the middle of the extent.
> 
> I also restarted testing on arm64, ppc64{,el}, and i686; it seems
> stable enough right now to pass all ~130 reflink xfstests here.

I see pretty reliable failures in xfs/128 xfs/132 xfs/139, apparenly
due to content mismatches.

Re the verifier failure:

sees like we're hitting the

	if (level >= pag->pagf_refcount_level)
		return false;

case.  Together with the other garbage in it seems like we're
seeing a btree block that's not properly initialized in some way,
maybe after a split.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-01-10  7:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-03 12:07 reflink fixes Christoph Hellwig
2016-01-03 12:07 ` [PATCH 1/3] xfs: pass inode instead of file to xfs_reflink_dirty_range Christoph Hellwig
2016-01-05  1:23   ` Darrick J. Wong
2016-01-03 12:07 ` [PATCH 2/3] xfs: only end a COW operation in xfs_zero_remaining_bytes if we started one Christoph Hellwig
2016-01-05  1:28   ` Darrick J. Wong
2016-01-03 12:07 ` [PATCH 3/3] xfs: cancel COW in xfs_cancel_ioend Christoph Hellwig
2016-01-05  1:43   ` Darrick J. Wong
2016-01-05 10:42     ` Christoph Hellwig
2016-01-07  0:32       ` Darrick J. Wong
2016-01-07 15:25         ` Christoph Hellwig
2016-01-08 10:09           ` Darrick J. Wong
2016-01-08 13:47             ` Christoph Hellwig
2016-01-09 21:17               ` Darrick J. Wong
2016-01-10  7:54                 ` Christoph Hellwig [this message]
2016-01-10 22:48     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160110075409.GA8213@lst.de \
    --to=hch@lst.de \
    --cc=darrick.wong@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.