From: Andrew Lunn <andrew@lunn.ch>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function
Date: Sun, 10 Jan 2016 18:21:09 +0100 [thread overview]
Message-ID: <20160110172109.GF22229@lunn.ch> (raw)
In-Reply-To: <56928539.1060009@roeck-us.net>
> drivers/net/ethernet/amd/au1000_eth.c: /* WARNING: bus->phy_map[phy_addr].attached_dev == dev does
> [ no idea what to do with that comment ]
That comment is very generic, it applies to all MDIO devices. So i'm
tempted to remove it. I will send a patch, probably tomorrow.
> drivers/net/ethernet/broadcom/sb1250-mac.c: phy_dev = sc->mii_bus->phy_map[i];
> [ can use phy_find_first ]
Yes, phy_find_first.
> drivers/staging/netlogic/xlr_net.c: struct phy_device *phydev = priv->mii_bus->phy_map[priv->phy_addr];
> [ several ]
Odd that i missed that file for phy_map, but did patch it for
phydev_name().
I will send a patch for that, but probably tomorrow.
Andrew
next prev parent reply other threads:[~2016-01-10 17:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 16:37 [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function Guenter Roeck
2016-01-09 16:37 ` [PATCH -next 2/2] net: bfin_mac: Fix build error due to missed API change Guenter Roeck
2016-01-09 16:58 ` [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function Andrew Lunn
2016-01-09 18:10 ` Guenter Roeck
2016-01-09 20:52 ` Andrew Lunn
2016-01-10 15:16 ` Guenter Roeck
2016-01-10 15:49 ` Andrew Lunn
2016-01-10 16:22 ` Guenter Roeck
2016-01-10 17:21 ` Andrew Lunn [this message]
2016-01-10 20:10 ` Guenter Roeck
2016-01-10 23:58 ` Andrew Lunn
2016-01-11 8:43 ` Sudip Mukherjee
2016-01-11 16:23 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160110172109.GF22229@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.