From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mfd: mt6397: convert to arch_initcall Date: Mon, 11 Jan 2016 05:49:32 +0000 Message-ID: <20160111054932.GH3331@x1> References: <1450862711-22124-1-git-send-email-henryc.chen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1450862711-22124-1-git-send-email-henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Henry Chen Cc: Samuel Ortiz , Sascha Hauer , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Flora Fu , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org T24gV2VkLCAyMyBEZWMgMjAxNSwgSGVucnkgQ2hlbiB3cm90ZToKCj4gU2luY2UgcGluY3RybCBv ciByZWd1bGF0b3Igb2YgbXQ2Mzk2IG5lZWQgdG8gaW5pdGlhbGl6ZSBlYXJsaWVyIHRvIGF2b2lk Cj4gcHJvYmUgZGVmZXJyaW5nLCBhbHNvIGNoYW5nZSB0aGUgY29yZSBkcml2ZXIgdG8gYXJjaF9p bml0LgoKVGhpcyBpcyBleGFjdGx5IHdoYXQgZGVmZXJyaW5nIHByb2JlIHdhcyBkZXNpZ25lZCBm b3I7IHNvIHRoYXQgeW91CmRvbid0IGhhdmUgdG8gbWVzcyBhcm91bmQgd2l0aCBpbml0Y2FsbCBv cmRlcmluZy4KCj4gU2lnbmVkLW9mZi1ieTogSGVucnkgQ2hlbiA8aGVucnljLmNoZW5AbWVkaWF0 ZWsuY29tPgo+IC0tLQo+ICBkcml2ZXJzL21mZC9tdDYzOTctY29yZS5jIHwgNiArKysrKy0KPiAg MSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL21mZC9tdDYzOTctY29yZS5jIGIvZHJpdmVycy9tZmQvbXQ2Mzk3LWNv cmUuYwo+IGluZGV4IDE3NDljMWMuLmFmOThiNGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tZmQv bXQ2Mzk3LWNvcmUuYwo+ICsrKyBiL2RyaXZlcnMvbWZkL210NjM5Ny1jb3JlLmMKPiBAQCAtMjg1 LDcgKzI4NSwxMSBAQCBzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciBtdDYzOTdfZHJpdmVy ID0gewo+ICAJfSwKPiAgfTsKPiAgCj4gLW1vZHVsZV9wbGF0Zm9ybV9kcml2ZXIobXQ2Mzk3X2Ry aXZlcik7Cj4gK3N0YXRpYyBpbnQgX19pbml0IG10NjM5N19jb3JlX2luaXQodm9pZCkKPiArewo+ ICsJcmV0dXJuIHBsYXRmb3JtX2RyaXZlcl9yZWdpc3RlcigmbXQ2Mzk3X2RyaXZlcik7Cj4gK30K PiArYXJjaF9pbml0Y2FsbChtdDYzOTdfY29yZV9pbml0KTsKPiAgCj4gIE1PRFVMRV9BVVRIT1Io IkZsb3JhIEZ1LCBNZWRpYVRlayIpOwo+ICBNT0RVTEVfREVTQ1JJUFRJT04oIkRyaXZlciBmb3Ig TWVkaWFUZWsgTVQ2Mzk3IFBNSUMiKTsKCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWljcm9lbGVj dHJvbmljcyBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0 d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxv ZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgt bWVkaWF0ZWsgbWFpbGluZyBsaXN0CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRl awo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 11 Jan 2016 05:49:32 +0000 Subject: [PATCH] mfd: mt6397: convert to arch_initcall In-Reply-To: <1450862711-22124-1-git-send-email-henryc.chen@mediatek.com> References: <1450862711-22124-1-git-send-email-henryc.chen@mediatek.com> Message-ID: <20160111054932.GH3331@x1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 23 Dec 2015, Henry Chen wrote: > Since pinctrl or regulator of mt6396 need to initialize earlier to avoid > probe deferring, also change the core driver to arch_init. This is exactly what deferring probe was designed for; so that you don't have to mess around with initcall ordering. > Signed-off-by: Henry Chen > --- > drivers/mfd/mt6397-core.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c > index 1749c1c..af98b4b 100644 > --- a/drivers/mfd/mt6397-core.c > +++ b/drivers/mfd/mt6397-core.c > @@ -285,7 +285,11 @@ static struct platform_driver mt6397_driver = { > }, > }; > > -module_platform_driver(mt6397_driver); > +static int __init mt6397_core_init(void) > +{ > + return platform_driver_register(&mt6397_driver); > +} > +arch_initcall(mt6397_core_init); > > MODULE_AUTHOR("Flora Fu, MediaTek"); > MODULE_DESCRIPTION("Driver for MediaTek MT6397 PMIC"); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758571AbcAKFu6 (ORCPT ); Mon, 11 Jan 2016 00:50:58 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36492 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758402AbcAKFtg (ORCPT ); Mon, 11 Jan 2016 00:49:36 -0500 Date: Mon, 11 Jan 2016 05:49:32 +0000 From: Lee Jones To: Henry Chen Cc: Samuel Ortiz , Matthias Brugger , Sascha Hauer , Flora Fu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] mfd: mt6397: convert to arch_initcall Message-ID: <20160111054932.GH3331@x1> References: <1450862711-22124-1-git-send-email-henryc.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1450862711-22124-1-git-send-email-henryc.chen@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Dec 2015, Henry Chen wrote: > Since pinctrl or regulator of mt6396 need to initialize earlier to avoid > probe deferring, also change the core driver to arch_init. This is exactly what deferring probe was designed for; so that you don't have to mess around with initcall ordering. > Signed-off-by: Henry Chen > --- > drivers/mfd/mt6397-core.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c > index 1749c1c..af98b4b 100644 > --- a/drivers/mfd/mt6397-core.c > +++ b/drivers/mfd/mt6397-core.c > @@ -285,7 +285,11 @@ static struct platform_driver mt6397_driver = { > }, > }; > > -module_platform_driver(mt6397_driver); > +static int __init mt6397_core_init(void) > +{ > + return platform_driver_register(&mt6397_driver); > +} > +arch_initcall(mt6397_core_init); > > MODULE_AUTHOR("Flora Fu, MediaTek"); > MODULE_DESCRIPTION("Driver for MediaTek MT6397 PMIC"); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog