From: Sascha Hauer <s.hauer@pengutronix.de>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH] FIT: make RSA signature verification configurable
Date: Mon, 11 Jan 2016 09:03:46 +0100 [thread overview]
Message-ID: <20160111080346.GL13058@pengutronix.de> (raw)
In-Reply-To: <CAGm1_ku4Q=diLnYF+d8vRUFPJcFCiGt1rrFvuik7xWC0JNLk1g@mail.gmail.com>
Hi Yegor,
On Fri, Jan 08, 2016 at 05:43:56PM +0100, Yegor Yefremov wrote:
> On Fri, Jan 8, 2016 at 5:11 PM, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> > On 01/08/2016 02:24 PM, yegorslists@googlemail.com wrote:
> >> From: Yegor Yefremov <yegorslists@googlemail.com>
> >> diff --git a/common/image-fit.c b/common/image-fit.c
> >> index 296285b..96cc3e2 100644
> >> --- a/common/image-fit.c
> >> +++ b/common/image-fit.c
> >> @@ -40,6 +40,7 @@
> >> #define CHECK_LEVEL_SIG 2
> >> #define CHECK_LEVEL_MAX 3
> >>
> >> +#ifdef CONFIG_CMD_BOOTM_FITIMAGE_SIGNATURE
> >> static uint32_t dt_struct_advance(struct fdt_header *f, uint32_t dt, int size)
> >
> > remove the ifdef.
>
> What about compile warnings, i.e. function defined, but not used?
This won't happen when you use IS_ENABLED().
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-01-11 8:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 13:24 [PATCH] FIT: make RSA signature verification configurable yegorslists
2016-01-08 16:11 ` Marc Kleine-Budde
2016-01-08 16:43 ` Yegor Yefremov
2016-01-10 18:14 ` Marc Kleine-Budde
2016-01-11 8:03 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111080346.GL13058@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.