From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/13] drm/i915: Avoid invariant conditionals in lrc interrupt handler Date: Mon, 11 Jan 2016 09:29:32 +0100 Message-ID: <20160111082932.GM8076@phenom.ffwll.local> References: <1452252592-24803-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1452252592-24803-4-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FC1B6E215 for ; Mon, 11 Jan 2016 00:29:32 -0800 (PST) Received: by mail-wm0-f68.google.com with SMTP id u188so25116527wmu.0 for ; Mon, 11 Jan 2016 00:29:32 -0800 (PST) Content-Disposition: inline In-Reply-To: <1452252592-24803-4-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKYW4gMDgsIDIwMTYgYXQgMTE6Mjk6NDJBTSArMDAwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiAKPiBUaGVyZSBpcyBubyBuZWVkIHRvIGNoZWNrIG9uIHdoYXQgR2VuIHdlIGFyZSBydW5uaW5n IG9uIGV2ZXJ5Cj4gaW50ZXJydXB0IGFuZCBldmVyeSBjb21tYW5kIHN1Ym1pc3Npb24uIFdlIGNh biBpbnN0ZWFkIHNldCB1cAo+IHNvbWUgb2YgdGhhdCB3aGVuIGVuZ2luZXMgYXJlIGluaXRpYWxp emVkLCBzdG9yZSBpdCBpbiB0aGUKPiBlbmdpbmUgc3RydWN0dXJlIGFuZCB1c2UgaXQgZGlyZWN0 bHkgYXQgcnVudGltZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtv LnVyc3VsaW5AaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s cmMuYyAgICAgICAgfCAzNiArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oIHwgIDIgKysKPiAgMiBmaWxlcyBj aGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9scmMuYwo+IGluZGV4IDhiNjA3MWZjZDc0My4uODQ5NzdhNmU2ZjNmIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtMjk4LDI5ICsyOTgsMTUgQEAgdWludDY0X3Qg aW50ZWxfbHJfY29udGV4dF9kZXNjcmlwdG9yKHN0cnVjdCBpbnRlbF9jb250ZXh0ICpjdHgsCj4g IAkJCQkgICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCj4gIHsKPiAgCXN0cnVjdCBk cm1faTkxNV9nZW1fb2JqZWN0ICpjdHhfb2JqID0gY3R4LT5lbmdpbmVbcmluZy0+aWRdLnN0YXRl Owo+IC0JdWludDY0X3QgZGVzYzsKPiArCXVpbnQ2NF90IGRlc2MgPSByaW5nLT5jdHhfZGVzY190 ZW1wbGF0ZTsKPiAgCXVpbnQ2NF90IGxyY2EgPSBpOTE1X2dlbV9vYmpfZ2d0dF9vZmZzZXQoY3R4 X29iaikgKwo+ICAJCQlMUkNfUFBIV1NQX1BOICogUEFHRV9TSVpFOwo+ICAKPiAgCVdBUk5fT04o bHJjYSAmIDB4RkZGRkZGRkYwMDAwMEZGRlVMTCk7Cj4gIAo+IC0JZGVzYyA9IEdFTjhfQ1RYX1ZB TElEOwo+IC0JZGVzYyB8PSBHRU44X0NUWF9BRERSRVNTSU5HX01PREUoZGV2KSA8PCBHRU44X0NU WF9BRERSRVNTSU5HX01PREVfU0hJRlQ7Cj4gLQlpZiAoSVNfR0VOOChjdHhfb2JqLT5iYXNlLmRl dikpCj4gLQkJZGVzYyB8PSBHRU44X0NUWF9MM0xMQ19DT0hFUkVOVDsKPiAtCWRlc2MgfD0gR0VO OF9DVFhfUFJJVklMRUdFOwo+ICAJZGVzYyB8PSBscmNhOwo+ICAJZGVzYyB8PSAodTY0KWludGVs X2V4ZWNsaXN0c19jdHhfaWQoY3R4X29iaikgPDwgR0VOOF9DVFhfSURfU0hJRlQ7Cj4gIAo+IC0J LyogVE9ETzogV2FEaXNhYmxlTGl0ZVJlc3RvcmUgd2hlbiB3ZSBzdGFydCB1c2luZyBzZW1hcGhv cmUKPiAtCSAqIHNpZ25hbGxpbmcgYmV0d2VlbiBDb21tYW5kIFN0cmVhbWVycyAqLwo+IC0JLyog ZGVzYyB8PSBHRU44X0NUWF9GT1JDRV9SRVNUT1JFOyAqLwo+IC0KPiAtCS8qIFdhRW5hYmxlRm9y Y2VSZXN0b3JlSW5DdHh0RGVzY0ZvclZDUzpza2wgKi8KPiAtCS8qIFdhRW5hYmxlRm9yY2VSZXN0 b3JlSW5DdHh0RGVzY0ZvclZDUzpieHQgKi8KPiAtCWlmIChkaXNhYmxlX2xpdGVfcmVzdG9yZV93 YShyaW5nKSkKPiAtCQlkZXNjIHw9IEdFTjhfQ1RYX0ZPUkNFX1JFU1RPUkU7Cj4gLQo+ICAJcmV0 dXJuIGRlc2M7Cj4gIH0KCnRiaCBJJ2QgZ28gZnVsbCBtb250eSBhbmQganVzdCBjYWNoZSB0aGUg ZW50aXJlIGNvbnRleHQgZGVzY3JpcHRvci4KLURhbmllbAoKPiAgCj4gQEAgLTU1Niw3ICs1NDIs NyBAQCB2b2lkIGludGVsX2xyY19pcnFfaGFuZGxlcihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpy aW5nKQo+ICAJCX0KPiAgCX0KPiAgCj4gLQlpZiAoZGlzYWJsZV9saXRlX3Jlc3RvcmVfd2Eocmlu ZykpIHsKPiArCWlmIChyaW5nLT5kaXNhYmxlX2xpdGVfcmVzdG9yZV93YSkgewo+ICAJCS8qIFBy ZXZlbnQgYSBjdHggdG8gcHJlZW1wdCBpdHNlbGYgKi8KPiAgCQlpZiAoKHN0YXR1cyAmIEdFTjhf Q1RYX1NUQVRVU19BQ1RJVkVfSURMRSkgJiYKPiAgCQkgICAgKHN1Ym1pdF9jb250ZXh0cyAhPSAw KSkKPiBAQCAtMTk4MCw2ICsxOTY2LDI0IEBAIHN0YXRpYyBpbnQgbG9naWNhbF9yaW5nX2luaXQo c3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluCj4gIAkJ Z290byBlcnJvcjsKPiAgCX0KPiAgCj4gKwlyaW5nLT5kaXNhYmxlX2xpdGVfcmVzdG9yZV93YSA9 IGRpc2FibGVfbGl0ZV9yZXN0b3JlX3dhKHJpbmcpOwo+ICsKPiArCXJpbmctPmN0eF9kZXNjX3Rl bXBsYXRlID0gR0VOOF9DVFhfVkFMSUQ7Cj4gKwlyaW5nLT5jdHhfZGVzY190ZW1wbGF0ZSB8PSBH RU44X0NUWF9BRERSRVNTSU5HX01PREUoZGV2KSA8PAo+ICsJCQkJICAgR0VOOF9DVFhfQUREUkVT U0lOR19NT0RFX1NISUZUOwo+ICsJaWYgKElTX0dFTjgoZGV2KSkKPiArCQlyaW5nLT5jdHhfZGVz Y190ZW1wbGF0ZSB8PSBHRU44X0NUWF9MM0xMQ19DT0hFUkVOVDsKPiArCXJpbmctPmN0eF9kZXNj X3RlbXBsYXRlIHw9IEdFTjhfQ1RYX1BSSVZJTEVHRTsKPiArCj4gKwkvKiBUT0RPOiBXYURpc2Fi bGVMaXRlUmVzdG9yZSB3aGVuIHdlIHN0YXJ0IHVzaW5nIHNlbWFwaG9yZQo+ICsJICogc2lnbmFs bGluZyBiZXR3ZWVuIENvbW1hbmQgU3RyZWFtZXJzICovCj4gKwkvKiByaW5nLT5jdHhfZGVzY190 ZW1wbGF0ZSB8PSBHRU44X0NUWF9GT1JDRV9SRVNUT1JFOyAqLwo+ICsKPiArCS8qIFdhRW5hYmxl Rm9yY2VSZXN0b3JlSW5DdHh0RGVzY0ZvclZDUzpza2wgKi8KPiArCS8qIFdhRW5hYmxlRm9yY2VS ZXN0b3JlSW5DdHh0RGVzY0ZvclZDUzpieHQgKi8KPiArCWlmIChyaW5nLT5kaXNhYmxlX2xpdGVf cmVzdG9yZV93YSkKPiArCQlyaW5nLT5jdHhfZGVzY190ZW1wbGF0ZSB8PSBHRU44X0NUWF9GT1JD RV9SRVNUT1JFOwo+ICsKPiAgCXJldHVybiAwOwo+ICAKPiAgZXJyb3I6Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IGluZGV4IDQ5NTc0ZmZlNTRiYy4uMGI5MWE0Yjc3 MzU5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIu aAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IEBAIC0y NjgsNiArMjY4LDggQEAgc3RydWN0ICBpbnRlbF9lbmdpbmVfY3Mgewo+ICAJc3RydWN0IGxpc3Rf aGVhZCBleGVjbGlzdF9xdWV1ZTsKPiAgCXN0cnVjdCBsaXN0X2hlYWQgZXhlY2xpc3RfcmV0aXJl ZF9yZXFfbGlzdDsKPiAgCXU4IG5leHRfY29udGV4dF9zdGF0dXNfYnVmZmVyOwo+ICsJYm9vbCBk aXNhYmxlX2xpdGVfcmVzdG9yZV93YTsKPiArCXUzMiBjdHhfZGVzY190ZW1wbGF0ZTsKPiAgCXUz MiAgICAgICAgICAgICBpcnFfa2VlcF9tYXNrOyAvKiBiaXRtYXNrIGZvciBpbnRlcnJ1cHRzIHRo YXQgc2hvdWxkIG5vdCBiZSBtYXNrZWQgKi8KPiAgCWludAkJKCplbWl0X3JlcXVlc3QpKHN0cnVj dCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCk7Cj4gIAlpbnQJCSgqZW1pdF9mbHVzaCko c3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0LAo+IC0tIAo+IDEuOS4xCj4gCj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1n ZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApE YW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8v YmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=