From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [rtc-linux] [PATCH 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 Date: Mon, 11 Jan 2016 09:05:01 +0000 Message-ID: <20160111090501.GG14104@x1> References: <1452177524-23192-1-git-send-email-ldewangan@nvidia.com> <1452177524-23192-3-git-send-email-ldewangan@nvidia.com> <20160111054627.GB3331@x1> <56934AFD.5060008@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <56934AFD.5060008@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski Cc: rtc-linux@googlegroups.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, swarren@nvidia.com, treding@nvidia.com, Laxman Dewangan , Chaitanya Bandi , Mallikarjun Kasoju List-Id: linux-gpio@vger.kernel.org On Mon, 11 Jan 2016, Krzysztof Kozlowski wrote: > On 11.01.2016 14:46, Lee Jones wrote: > > On Fri, 08 Jan 2016, Krzysztof Kozlowski wrote: > >=20 > > Thanks for taking the time to review. > >=20 > >> ()2016-01-07 23:38 GMT+09:00 Laxman Dewangan : > >>> MAX77620/MAX20024 are Power Management IC from the MAXIM. > >>> It supports RTC, multiple GPIOs, multiple DCDC and LDOs, > >>> watchdog, clock etc. > >>> > >>> Add MFD drier to provides common support for accessing the > >>> device; additional drivers is developed on respected subsystem > >>> in order to use the functionality of the device. > >>> > >>> Signed-off-by: Laxman Dewangan > >>> Signed-off-by: Chaitanya Bandi > >>> Signed-off-by: Mallikarjun Kasoju > >>> Tested-by: Venkat Reddy Talla > >> > >> The Testing and Reviewed are statements (see SubmittingPatches) so > >> they should be made explicitly by people. As this is v1 how they c= ould > >> make a public statement so far? > >=20 > > SubmittingPatches bears no mention that Reviewed-by/Tested-by > > statements have to be provided on one of the public mailing lists. > > These can be provided privately prior to upstream submission v1. >=20 > Indeed the document does not mention that they have to be provided by > public. >=20 > In the same time these are statements given by a reviewer ("By offeri= ng > my Reviewed-by: tag, I state that:")... and how can you validate a > statement given through a private channel? Is it true? Is it a thorou= gh > testing or just copy-paste from Gerrit (or other automated system)? That is for the submitter's conscience to decide. If the statements are supplied, we must assume they were provided in good faith and in accordance with the rules set out by the Linux Kernel. We can not ask for every Tested-by/Acked-by/Reviewed-by/etc provider to verify on each upstream submission. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com. [2a00:1450:400c:c09::22a]) by gmr-mx.google.com with ESMTPS id w129si408081wme.1.2016.01.11.01.05.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jan 2016 01:05:05 -0800 (PST) Received: by mail-wm0-x22a.google.com with SMTP id l65so201787895wmf.1 for ; Mon, 11 Jan 2016 01:05:05 -0800 (PST) Date: Mon, 11 Jan 2016 09:05:01 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: rtc-linux@googlegroups.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, swarren@nvidia.com, treding@nvidia.com, Laxman Dewangan , Chaitanya Bandi , Mallikarjun Kasoju Subject: Re: [rtc-linux] [PATCH 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 Message-ID: <20160111090501.GG14104@x1> References: <1452177524-23192-1-git-send-email-ldewangan@nvidia.com> <1452177524-23192-3-git-send-email-ldewangan@nvidia.com> <20160111054627.GB3331@x1> <56934AFD.5060008@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <56934AFD.5060008@samsung.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Mon, 11 Jan 2016, Krzysztof Kozlowski wrote: > On 11.01.2016 14:46, Lee Jones wrote: > > On Fri, 08 Jan 2016, Krzysztof Kozlowski wrote: > >=20 > > Thanks for taking the time to review. > >=20 > >> ()2016-01-07 23:38 GMT+09:00 Laxman Dewangan : > >>> MAX77620/MAX20024 are Power Management IC from the MAXIM. > >>> It supports RTC, multiple GPIOs, multiple DCDC and LDOs, > >>> watchdog, clock etc. > >>> > >>> Add MFD drier to provides common support for accessing the > >>> device; additional drivers is developed on respected subsystem > >>> in order to use the functionality of the device. > >>> > >>> Signed-off-by: Laxman Dewangan > >>> Signed-off-by: Chaitanya Bandi > >>> Signed-off-by: Mallikarjun Kasoju > >>> Tested-by: Venkat Reddy Talla > >> > >> The Testing and Reviewed are statements (see SubmittingPatches) so > >> they should be made explicitly by people. As this is v1 how they could > >> make a public statement so far? > >=20 > > SubmittingPatches bears no mention that Reviewed-by/Tested-by > > statements have to be provided on one of the public mailing lists. > > These can be provided privately prior to upstream submission v1. >=20 > Indeed the document does not mention that they have to be provided by > public. >=20 > In the same time these are statements given by a reviewer ("By offering > my Reviewed-by: tag, I state that:")... and how can you validate a > statement given through a private channel? Is it true? Is it a thorough > testing or just copy-paste from Gerrit (or other automated system)? That is for the submitter's conscience to decide. If the statements are supplied, we must assume they were provided in good faith and in accordance with the rules set out by the Linux Kernel. We can not ask for every Tested-by/Acked-by/Reviewed-by/etc provider to verify on each upstream submission. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.