From: Darren Hart <dvhart@infradead.org>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Qipeng Zha <qipeng.zha@intel.com>,
platform-driver-x86@vger.kernel.org,
andriy.shevchenko@linux.intel.com,
souvik.k.chakravarty@intel.com
Subject: Re: [PATCH] intel_punit_ipc: add NULL check for input parameters
Date: Mon, 11 Jan 2016 09:52:29 -0800 [thread overview]
Message-ID: <20160111175229.GA10643@malice.jf.intel.com> (raw)
In-Reply-To: <20160108112644.4a64e49e@lxorguk.ukuu.org.uk>
On Fri, Jan 08, 2016 at 11:26:44AM +0000, One Thousand Gnomes wrote:
> On Fri, 8 Jan 2016 18:32:27 +0800
> Qipeng Zha <qipeng.zha@intel.com> wrote:
>
> > intel_punit_ipc_command() maybe called when in or out
> > data pointers are NULL.
>
> In which case what happens: the command is not issued but there seems to
> be no way for the caller to discover this, and nohing is logged.
>
> Alan
>
These functinos are not void, it seems an errcode or a message is in order.
Also, the commit message needs to document in what scenario
intel_punit_ipc_command() may be called with null pointers - and why we consider
that to be OK.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2016-01-11 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 10:32 [PATCH] intel_punit_ipc: add NULL check for input parameters Qipeng Zha
2016-01-08 11:26 ` One Thousand Gnomes
2016-01-11 17:52 ` Darren Hart [this message]
2016-01-12 3:59 ` Chakravarty, Souvik K
2016-01-14 22:22 ` Darren Hart
2016-01-14 22:23 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111175229.GA10643@malice.jf.intel.com \
--to=dvhart@infradead.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
--cc=souvik.k.chakravarty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.