Re: [PATCH] extensions: libip6t_hl: Add translation to nft

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Thu, Jan 07, 2016 at 03:09:24PM +0530, Shivani Bhardwaj wrote:
> Add translation for hop limit to nftables.
> 
> Examples:
> 
> $ sudo ip6tables-translate -t nat -A postrouting -m hl --hl-gt 3
> nft add rule ip6 nat postrouting ip6 hoplimit gt 3 counter
> 
> $ sudo ip6tables-translate -t nat -A postrouting -m hl ! --hl-eq 3
> nft add rule ip6 nat postrouting ip6 hoplimit != 3 counter
> 
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
>  extensions/libip6t_hl.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/extensions/libip6t_hl.c b/extensions/libip6t_hl.c
> index 3559db4..0e13df1 100644
> --- a/extensions/libip6t_hl.c
> +++ b/extensions/libip6t_hl.c
> @@ -97,6 +97,23 @@ static const struct xt_option_entry hl_opts[] = {
>  };
>  #undef s
>  
> +static int hl_xlate(const struct xt_entry_match *match,
> +		    struct xt_buf *buf, int numeric)
> +{
> +	static const char *const op[] = {
> +		[IP6T_HL_EQ] = "ip6 hoplimit",
> +		[IP6T_HL_NE] = "ip6 hoplimit !=",
> +		[IP6T_HL_LT] = "ip6 hoplimit lt",
> +		[IP6T_HL_GT] = "ip6 hoplimit gt" };

I'd suggest you use something like:

	static const char *const op[] = {
                [IP6T_HL_EQ] = "",
                [IP6T_HL_NE] = "!=",
                [IP6T_HL_LT] = "lt",
                [IP6T_HL_GT] = "gt"
        };

We can later on consolidate this code by providing a common function
from libxtables for everyone.

Thanks.