From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [PATCH v1 1/1] rtc: cmos: prevent kernel warning on IRQ flags mismatch
Date: Mon, 11 Jan 2016 20:38:34 +0100 [thread overview]
Message-ID: <20160111193834.GE3367@piout.net> (raw)
In-Reply-To: <1450892239-74224-1-git-send-email-andriy.shevchenko@linux.intel.com>
On 23/12/2015 at 19:37:19 +0200, Andy Shevchenko wrote :
> The Microsoft Surface 3 tablet shares interrupt line between RTC and one of SPI
> controllers. However, the rtc_cmos driver doesn't allow shared interrupts and
> user sees the following warning
>
> genirq: Flags mismatch irq 8. 00000080 (8086228E:02) vs. 00000000 (rtc0)
> ...
> [<ffffffffa004eb01>] pxa2xx_spi_probe+0x151/0x600 [spi_pxa2xx_platform]
>
> Allow RTC driver to use shared interrupts.
>
> Seems we are on the safe side to do just this simple change since
> cmos_interrupt() handler checks for the actual hardware status anyway.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/rtc/rtc-cmos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2016-01-11 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 17:37 [rtc-linux] [PATCH v1 1/1] rtc: cmos: prevent kernel warning on IRQ flags mismatch Andy Shevchenko
2016-01-11 19:38 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111193834.GE3367@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.