From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1761569AbcAKWOn (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jan 2016 17:14:43 -0500
Received: from bombadil.infradead.org ([198.137.202.9]:44184 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759421AbcAKWOl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jan 2016 17:14:41 -0500
Date: Mon, 11 Jan 2016 23:14:36 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Ameen <ameenali023@gmail.com>, mingo@kernel.org, mhocko@suse.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Use num_possible_cpus() instead of direct use of
 NR_CPUS.
Message-ID: <20160111221436.GL6344@twins.programming.kicks-ass.net>
References: <1452438805-3205-1-git-send-email-AmeenAli023@gmail.com>
 <5693B22E.3070409@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5693B22E.3070409@suse.cz>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 11, 2016 at 02:46:22PM +0100, Vlastimil Babka wrote:
> On 01/10/2016 04:13 PM, Ameen wrote:
> > WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus()..
> 
> Is that a checkpatch warning? Notice the word "often". You need to provide info
> why it's the case here (and I doubt the change will be corect in this case).

Yeah, this is terminally broken.