From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v3 09/12] virtio: vfio: Enable
 RTE_PCI_DRV_NEED_MAPPING flag in driver
Date: Tue, 12 Jan 2016 15:14:17 +0800
Message-ID: <20160112071417.GO26062@yliu-dev.sh.intel.com>
References: <1452184390-5994-1-git-send-email-sshukla@mvista.com>
 <1452184390-5994-10-git-send-email-sshukla@mvista.com>
 <20160107102058.43499eae@xeon-e3>
 <CAAyOgsbAkD=FEecYJ7jCcB5JBc8x34i9uX4e2yiabgvZsY+S3g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Santosh Shukla <sshukla@mvista.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id DD39F5693
 for <dev@dpdk.org>; Tue, 12 Jan 2016 08:13:22 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <CAAyOgsbAkD=FEecYJ7jCcB5JBc8x34i9uX4e2yiabgvZsY+S3g@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, Jan 09, 2016 at 06:08:46PM +0530, Santosh Shukla wrote:
> On Thu, Jan 7, 2016 at 11:50 PM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > On Thu,  7 Jan 2016 22:03:06 +0530
> > Santosh Shukla <sshukla@mvista.com> wrote:
> >
> >> +#ifdef RTE_EAL_VFIO
> >> +             .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_DETACHABLE,
> >> +#else
> >>               .drv_flags = RTE_PCI_DRV_DETACHABLE,
> >> +#endif
> >
> > Since VFIO is determined at runtime not compile time, the flags should
> > be updated at runtime not compile time.
> >
> >
> In general, Yes, Its a wrong approach i..e. Wrapping __need_mapping
> flag only for vfio case. I am thinking to add vfio parser routine
> something similar to virtio_xxx_xx_uio_xx() / virtio_xx_xx_ioport()
> currently exist. This will remove RTE_EAL_VFIO ifdef clutter for this
> patch and [08/12] patch and also virtio pmd driver can then initialize
> device for vfio mode..
> 
> _but_ I still need _MAPPING flag enabled for in virtio driver as
> because for vfio case - I want vfio_xx_mmap() routine to create vfio
> container/group_id and then create vfio_dev_fd for each virtio-net-pci
> interface.

I'm thinking my following patch will help:

    http://dpdk.org/dev/patchwork/patch/9814/

	--yliu

> Let me know my approach aligned to your suggestion.