From: Pratyush Anand <panand@redhat.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: geoff@infradead.org, kexec@lists.infradead.org,
horms@verge.net.au, james.morse@arm.com, jk@ozlabs.org,
scottwood@freescale.com, dyoung@redhat.com, vgoyal@redhat.com,
ebiederm@xmission.com
Subject: Re: [PATCH RFC V2 2/2] arm64: Pass RAM boundary and enable-dcache flag to purgatory
Date: Tue, 12 Jan 2016 15:25:28 +0530 [thread overview]
Message-ID: <20160112095528.GK21206@dhcppc13.redhat.com> (raw)
In-Reply-To: <5694BB9F.5050801@linaro.org>
Hi Akashi,
On 12/01/2016:05:38:55 PM, AKASHI Takahiro wrote:
> On 01/12/2016 02:12 PM, Pratyush Anand wrote:
> >When "enable-dcache" is passed to the kexec() command line, kexec-tools
> >passes this information to purgatory, which in turn enables cache during
> >sha-256 verification.
> >
> >RAM boundary which includes all the sections is needed for creating
> >identity page mapping and to enable d-cache for those areas. Therefore
> >these informations are passed to purgatory as well.
> >
> >Signed-off-by: Pratyush Anand <panand@redhat.com>
> >---
> > kexec/arch/arm64/include/arch/options.h | 6 +++++-
> > kexec/arch/arm64/include/types.h | 16 ++++++++++++++++
> > kexec/arch/arm64/kexec-arm64.c | 24 +++++++++++++++++++++++-
> > purgatory/arch/arm64/entry.S | 15 +++++++++++++++
> > purgatory/arch/arm64/purgatory-arm64.c | 10 +++++++++-
> > 5 files changed, 68 insertions(+), 3 deletions(-)
> > create mode 100644 kexec/arch/arm64/include/types.h
> >
> >diff --git a/kexec/arch/arm64/include/arch/options.h b/kexec/arch/arm64/include/arch/options.h
> >index fbe17de595a9..3d84bb12ee37 100644
> >--- a/kexec/arch/arm64/include/arch/options.h
> >+++ b/kexec/arch/arm64/include/arch/options.h
> >@@ -8,7 +8,8 @@
> > #define OPT_PORT ((OPT_MAX)+4)
> > #define OPT_REUSE_CMDLINE ((OPT_MAX)+5)
> > #define OPT_PORT_LSR ((OPT_MAX)+6)
> >-#define OPT_ARCH_MAX ((OPT_MAX)+7)
> >+#define OPT_ENABLE_DCACHE ((OPT_MAX)+7)
> >+#define OPT_ARCH_MAX ((OPT_MAX)+8)
> >
> > #define KEXEC_ARCH_OPTIONS \
> > KEXEC_OPTIONS \
> >@@ -20,6 +21,7 @@
> > { "port", 1, NULL, OPT_PORT }, \
> > { "port-lsr", 1, NULL, OPT_PORT_LSR }, \
> > { "ramdisk", 1, NULL, OPT_INITRD }, \
> >+ { "enable-dcache", 0, NULL, OPT_ENABLE_DCACHE }, \
>
> in alphabetical order, please.
OK
>
> > { "reuse-cmdline", 0, NULL, OPT_REUSE_CMDLINE }, \
> >
> > #define KEXEC_ARCH_OPT_STR KEXEC_OPT_STR /* Only accept long arch options. */
> >@@ -33,6 +35,7 @@ static const char arm64_opts_usage[] __attribute__ ((unused)) =
> > " --initrd=FILE Use FILE as the kernel initial ramdisk.\n"
> > " --port=ADDRESS Purgatory output to port ADDRESS.\n"
> > " --port-lsr=ADDR,VAL Purgatory output port line status address and TX Empty Bit Field.\n"
> >+" --enable-dcache Enable D-Cache in Purgatory for faster SHA verification.\n"
>
> ditto :)
OK.
Thanks for quick review.
Will wait for some time to get more feedback and then will send next version.
~Pratyush
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2016-01-12 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 5:12 [PATCH RFC V2 0/2] kexec: arm64: purgatory: cache support Pratyush Anand
2016-01-12 5:12 ` [PATCH RFC V2 1/2] arm64: Add enable/disable d-cache support for purgatory Pratyush Anand
2016-01-12 8:34 ` AKASHI Takahiro
2016-01-12 9:53 ` Pratyush Anand
2016-01-13 4:35 ` AKASHI Takahiro
2016-01-13 5:44 ` Pratyush Anand
2016-01-12 5:12 ` [PATCH RFC V2 2/2] arm64: Pass RAM boundary and enable-dcache flag to purgatory Pratyush Anand
2016-01-12 8:38 ` AKASHI Takahiro
2016-01-12 9:55 ` Pratyush Anand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112095528.GK21206@dhcppc13.redhat.com \
--to=panand@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=geoff@infradead.org \
--cc=horms@verge.net.au \
--cc=james.morse@arm.com \
--cc=jk@ozlabs.org \
--cc=kexec@lists.infradead.org \
--cc=scottwood@freescale.com \
--cc=takahiro.akashi@linaro.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.