From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39724)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aIyOB-0002gV-It
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 07:49:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aIyO7-0006Ii-Sx
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 07:49:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35951)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aIyO7-0006IX-NY
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 07:49:27 -0500
Date: Tue, 12 Jan 2016 12:49:22 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160112124922.GH17626@redhat.com>
References: <1452601779-5790-1-git-send-email-kraxel@redhat.com>
	<1452601779-5790-5-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1452601779-5790-5-git-send-email-kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/7] qapi: rename input buttons
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <andreas.faerber@web.de>

On Tue, Jan 12, 2016 at 01:29:37PM +0100, Gerd Hoffmann wrote:
> All lowercase, use-dash instead of CamelCase.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/input/hid.c              | 4 ++--
>  hw/input/ps2.c              | 4 ++--
>  hw/input/virtio-input-hid.c | 4 ++--
>  monitor.c                   | 2 +-
>  qapi-schema.json            | 5 +----
>  qmp-commands.hx             | 4 ++--
>  ui/cocoa.m                  | 4 ++--
>  ui/gtk.c                    | 4 ++--
>  ui/input-legacy.c           | 4 ++--
>  ui/sdl.c                    | 4 ++--
>  ui/sdl2.c                   | 4 ++--
>  ui/spice-input.c            | 4 ++--
>  ui/vnc.c                    | 4 ++--
>  13 files changed, 24 insertions(+), 27 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


> diff --git a/qapi-schema.json b/qapi-schema.json
> index 3884479..511702f 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3662,12 +3662,9 @@
>  # Button of a pointer input device (mouse, tablet).
>  #
>  # Since: 2.0
> -#
> -# Note that the spelling of these values may change when the
> -# x-input-send-event is promoted out of experimental status.
>  ##
>  { 'enum'  : 'InputButton',
> -  'data'  : [ 'Left', 'Middle', 'Right', 'WheelUp', 'WheelDown' ] }
> +  'data'  : [ 'left', 'middle', 'right', 'wheel-up', 'wheel-down' ] }

Ok, this rename is safe todo, since this enum is only used from the
experimental x-input-send-event command

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|