From: Stephen Hemminger <stephen@networkplumber.org>
To: Yong Wang <yongwang@vmware.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v4 0/6] vmxnet3 TSO, tx cksum offload and cleanups
Date: Tue, 12 Jan 2016 20:56:34 -0800 [thread overview]
Message-ID: <20160112205634.7bd2d50d@xeon-e3> (raw)
In-Reply-To: <1452650917-7960-1-git-send-email-yongwang@vmware.com>
On Tue, 12 Jan 2016 18:08:31 -0800
Yong Wang <yongwang@vmware.com> wrote:
> v4:
> * moved cleanups to separate patches
> * correctly handled multi-seg pkts with data ring used
>
> v3:
> * fixed comments from Stephen
> * added performance number for tx data ring
>
> v2:
> * fixed some logging issues when debug option turned on
> * updated the txq_flags check in vmxnet3_dev_tx_queue_setup()
>
> This patchset adds TCP/UDP checksum offload and TSO to vmxnet3 PMD.
> One of the use cases is to support STT. It also restores the tx
> data ring feature that was removed from a previous patch.
>
> Yong Wang (6):
> vmxnet3: fix typos and remove unused struct
> vmxnet3: restore tx data ring support
> vmxnet3: cleanup txNumDeferred usage
> vmxnet3: add tx l4 cksum offload
> vmxnet3: add TSO support
> vmxnet3: announce device offload capability
>
> doc/guides/rel_notes/release_2_3.rst | 11 +++
> drivers/net/vmxnet3/base/includeCheck.h | 39 --------
> drivers/net/vmxnet3/base/vmxnet3_defs.h | 9 +-
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 16 +++-
> drivers/net/vmxnet3/vmxnet3_ring.h | 13 ---
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 160 +++++++++++++++++++++++++-------
> 6 files changed, 151 insertions(+), 97 deletions(-)
> delete mode 100644 drivers/net/vmxnet3/base/includeCheck.h
>
Looks good. The only thing maybe worth adding would be some more checks
int the vmxnet3_dev_configure for unsupported offload bits, etc.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2016-01-13 4:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 2:08 [PATCH v4 0/6] vmxnet3 TSO, tx cksum offload and cleanups Yong Wang
2016-01-13 2:08 ` [PATCH v4 1/6] vmxnet3: fix typos and remove unused struct Yong Wang
2016-01-13 2:08 ` [PATCH v4 2/6] vmxnet3: restore tx data ring support Yong Wang
2016-01-13 2:08 ` [PATCH v4 3/6] vmxnet3: cleanup txNumDeferred usage Yong Wang
2016-01-13 2:08 ` [PATCH v4 4/6] vmxnet3: add tx l4 cksum offload Yong Wang
2016-01-13 2:08 ` [PATCH v4 5/6] vmxnet3: add TSO support Yong Wang
2016-03-15 20:39 ` Thomas Monjalon
2016-01-13 2:08 ` [PATCH v4 6/6] vmxnet3: announce device offload capability Yong Wang
2016-01-13 4:56 ` Stephen Hemminger [this message]
2016-02-10 12:30 ` [PATCH v4 0/6] vmxnet3 TSO, tx cksum offload and cleanups Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112205634.7bd2d50d@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.