From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_db: check on-disk structure sizes
Date: Wed, 13 Jan 2016 16:47:30 +1100 [thread overview]
Message-ID: <20160113054730.GQ10456@dastard> (raw)
In-Reply-To: <5695C01F.7030807@sandeen.net>
On Tue, Jan 12, 2016 at 09:10:23PM -0600, Eric Sandeen wrote:
>
>
> On 1/12/16 7:29 PM, Darrick J. Wong wrote:
> > On Tue, Jan 12, 2016 at 09:01:22AM -0500, Brian Foster wrote:
> >> On Mon, Jan 11, 2016 at 03:46:44PM -0800, Darrick J. Wong wrote:
> >>> Check on-disk structure sizes against known values.
> >>> Use this to catch inadvertent changes in structure size due to padding
> >>> and alignment issues, etc.
> >>>
> >>> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> >>> ---
> >>
> >> What's the need for this in userspace? Not a big deal really, but it
> >> seems like it serves the fundamental purpose sufficiently in the kernel.
> >
> > The primary point is to make sure that we didn't make any errors with the
> > on-disk structures when porting libxfs changes. The kernel build is the first
> > line of defense since it tends to big get changes first, but I figure a
> > defensive build check for xfsprogs won't harm anyone...
>
> Does it need to actually be in the code?
>
> $ pahole -s fs/xfs/xfs.ko | grep -w "xfs_dsb\|xfs_agf\|xfs_agi\|xfs_agfl"
> xfs_agf 224 0
> xfs_agfl 40 0
> xfs_agi 336 0
> xfs_dsb 264 0
>
> pahole needs a binary w/ debuginfo, but maybe this could just be hooked up
> in the Makefiles?
As I've pointed out previously to Darrick: xfstests:/tests/xfs/122
Make that build again, update it.
-Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-01-13 5:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 23:46 [PATCH] xfs_db: check on-disk structure sizes Darrick J. Wong
2016-01-12 14:01 ` Brian Foster
2016-01-13 1:29 ` Darrick J. Wong
2016-01-13 3:10 ` Eric Sandeen
2016-01-13 5:47 ` Dave Chinner [this message]
2016-01-13 6:02 ` Eric Sandeen
2016-01-13 7:46 ` Christoph Hellwig
2016-01-15 20:56 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113054730.GQ10456@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.