From: "Pali Rohár" <pali.rohar@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Darren Hart <dvhart@infradead.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Fabio D'Urso <fabiodurso@hotmail.it>
Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight
Date: Wed, 13 Jan 2016 09:54:55 +0100 [thread overview]
Message-ID: <20160113085455.GD11560@pali> (raw)
In-Reply-To: <20160112215804.GA12869@amd>
On Tuesday 12 January 2016 22:58:04 Pavel Machek wrote:
> Hi!
>
> On Mon 2016-01-11 21:03:01, Pali Rohár wrote:
> > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote
> > > The two features are not the same (and are handled differently by the
> > > firmware, for whatever reason), although they do serve the same
> > > purpose. I don't think a thinkpad will ever have both features at
> > > the same time, so I have no idea why they changed the firmware
> > > interface.
> >
> > Maybe we should decide if ::kbd_backlight LED suffix could be used also
> > for other LED devices and not only for those which are physically under
> > the keyboard.
>
> Another problem is that N900 has _6_ backlight LEDs. Named
> lp5523::kb1..6. ... Which does means desktop software will probably
> not pick them up :-(.
>
> I guess we could have "/sys/class/kbd_light/brightness" that would
> control all of them with one write.
Probably... But there is problem that lp5523 is not ordinary on/off
light, it can be programmed to execute own "light" application.
> Next question is.. apparently there are some keyboards that have
> per-key RGB backlight... but maybe we can just call that "weird
> enough" and ignore...
First we need to defines stable kernel ABI for keyboard backlight. And I
suggest to use existing convention used by upower/console-kit and other
userspace apps...
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2016-01-13 8:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 18:46 [PATCH] thinkpad_acpi: Add support for keyboard backlight Pali Rohár
2015-12-27 23:14 ` Henrique de Moraes Holschuh
2015-12-28 14:48 ` Pali Rohár
2015-12-30 22:28 ` Pali Rohár
2016-01-06 8:45 ` Pali Rohár
2016-01-09 17:36 ` Henrique de Moraes Holschuh
2015-12-30 22:27 ` [PATCH v2] " Pali Rohár
2016-01-04 20:04 ` Darren Hart
2016-01-04 20:26 ` Pali Rohár
2016-01-04 20:40 ` Darren Hart
2016-01-04 20:51 ` Pali Rohár
2016-01-04 21:42 ` Darren Hart
2016-01-09 17:34 ` Henrique de Moraes Holschuh
2016-01-04 20:12 ` [PATCH] " Pavel Machek
2016-01-04 20:23 ` Pali Rohár
2016-01-04 20:40 ` Pali Rohár
2016-01-09 17:39 ` Henrique de Moraes Holschuh
[not found] ` <1452361154.673684.487414482.6CCEAE4B-2RFepEojUI2N1INw9kWLP6GC3tUn3ZHUQQ4Iyu8u01E@public.gmane.org>
2016-01-09 17:46 ` Henrique de Moraes Holschuh
2016-01-09 17:46 ` Henrique de Moraes Holschuh
2016-01-11 19:04 ` Darren Hart
2016-01-11 19:28 ` Henrique de Moraes Holschuh
2016-01-11 20:03 ` Pali Rohár
2016-01-11 21:12 ` Johannes Stezenbach
2016-01-12 16:07 ` Henrique de Moraes Holschuh
2016-01-12 16:23 ` [ibm-acpi-devel] " Yves-Alexis Perez
2016-01-12 16:35 ` Johannes Stezenbach
2016-01-12 17:56 ` Henrique de Moraes Holschuh
2016-01-12 22:07 ` Johannes Stezenbach
2016-01-12 18:11 ` [ibm-acpi-devel] " Kevin Locke
2016-01-12 18:20 ` Henrique de Moraes Holschuh
2016-01-12 18:36 ` Kevin Locke
2016-01-12 16:04 ` Henrique de Moraes Holschuh
2016-01-12 21:58 ` Pavel Machek
2016-01-13 8:54 ` Pali Rohár [this message]
2016-01-13 19:07 ` Pavel Machek
2016-01-13 19:10 ` Pavel Machek
2016-01-21 8:57 ` Pali Rohár
2016-01-11 22:44 ` [ibm-acpi-devel] " Yves-Alexis Perez
2016-01-12 16:59 ` Darren Hart
2016-01-12 17:51 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113085455.GD11560@pali \
--to=pali.rohar@gmail.com \
--cc=dvhart@infradead.org \
--cc=fabiodurso@hotmail.it \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.