From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Pan Subject: Re: [PATCH v3 22/22] thermal/intel_powerclamp: Convert the kthread to kthread worker API Date: Wed, 13 Jan 2016 09:53:53 -0800 Message-ID: <20160113095353.5231c28f@yairi> References: <1447853127-3461-1-git-send-email-pmladek@suse.com> <1447853127-3461-23-git-send-email-pmladek@suse.com> <20160107115531.34279a9b@icelake> <20160108164931.GT3178@pathway.suse.cz> <20160111181718.0ace4a58@yairi> <20160112101129.GN731@pathway.suse.cz> <20160112082021.6a28dc66@icelake> <20160113101831.GQ731@pathway.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160113101831.GQ731@pathway.suse.cz> Sender: owner-linux-mm@kvack.org To: Petr Mladek Cc: Andrew Morton , Oleg Nesterov , Tejun Heo , Ingo Molnar , Peter Zijlstra , Steven Rostedt , "Paul E. McKenney" , Josh Triplett , Thomas Gleixner , Linus Torvalds , Jiri Kosina , Borislav Petkov , Michal Hocko , linux-mm@kvack.org, Vlastimil Babka , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-pm@vger.kernel.org, jacob.jun.pan@linux.intel.com List-Id: linux-api@vger.kernel.org On Wed, 13 Jan 2016 11:18:31 +0100 Petr Mladek wrote: > > unsigned int __read_mostly freeze_timeout_msecs = 20 * > > MSEC_PER_SEC; > > You are right. And it does not make sense to add an extra > freezer-specific code if not really necessary. > > Otherwise, I will keep the conversion into the kthread worker as is > for now. Please, let me know if you are strongly against the split > into the two works. I am fine with the split now. Another question, are you planning to convert acpi_pad.c as well? It uses kthread similar way. Jacob -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932565AbcAMRyS (ORCPT ); Wed, 13 Jan 2016 12:54:18 -0500 Received: from mga04.intel.com ([192.55.52.120]:26073 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932528AbcAMRyK (ORCPT ); Wed, 13 Jan 2016 12:54:10 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,290,1449561600"; d="scan'208";a="892514209" Date: Wed, 13 Jan 2016 09:53:53 -0800 From: Jacob Pan To: Petr Mladek Cc: Andrew Morton , Oleg Nesterov , Tejun Heo , Ingo Molnar , Peter Zijlstra , Steven Rostedt , "Paul E. McKenney" , Josh Triplett , Thomas Gleixner , Linus Torvalds , Jiri Kosina , Borislav Petkov , Michal Hocko , linux-mm@kvack.org, Vlastimil Babka , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-pm@vger.kernel.org, jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v3 22/22] thermal/intel_powerclamp: Convert the kthread to kthread worker API Message-ID: <20160113095353.5231c28f@yairi> In-Reply-To: <20160113101831.GQ731@pathway.suse.cz> References: <1447853127-3461-1-git-send-email-pmladek@suse.com> <1447853127-3461-23-git-send-email-pmladek@suse.com> <20160107115531.34279a9b@icelake> <20160108164931.GT3178@pathway.suse.cz> <20160111181718.0ace4a58@yairi> <20160112101129.GN731@pathway.suse.cz> <20160112082021.6a28dc66@icelake> <20160113101831.GQ731@pathway.suse.cz> Organization: OTC X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Jan 2016 11:18:31 +0100 Petr Mladek wrote: > > unsigned int __read_mostly freeze_timeout_msecs = 20 * > > MSEC_PER_SEC; > > You are right. And it does not make sense to add an extra > freezer-specific code if not really necessary. > > Otherwise, I will keep the conversion into the kthread worker as is > for now. Please, let me know if you are strongly against the split > into the two works. I am fine with the split now. Another question, are you planning to convert acpi_pad.c as well? It uses kthread similar way. Jacob