From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/3 nft] tests/py: don't test log statement from protocol match
Date: Wed, 13 Jan 2016 12:07:53 +0100 [thread overview]
Message-ID: <20160113110753.GD1195@salvia> (raw)
In-Reply-To: <20160113101336.GA27674@breakpoint.cc>
On Wed, Jan 13, 2016 at 11:13:36AM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
>
> [ zap log rules from family matches ]
>
> I assume thats because you deem tests/py/any/log.t
> sufficient?
I think this unit tests should be self-contained at some level. The
shell/ directory should be used to catch regressions at ruleset level,
ie. these kind of combinations.
Another motivation is that I want that netdev/ingress gets tested, and
we don't support log there yet, so I would need to skip this test for
that case.
> When you push it can you add one-liner summary in this direction?
I'm going to include this information above. Let me know if you have
any other concern, thanks Florian.
next prev parent reply other threads:[~2016-01-13 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 22:40 [PATCH 1/3 nft] tests/py: don't test log statement from protocol match Pablo Neira Ayuso
2016-01-12 22:40 ` [PATCH 2/3 nft] tests/py: test udp from ip and ip6 families Pablo Neira Ayuso
2016-01-12 22:40 ` [PATCH 3/3 nft] tests/py: netdev family with ingress chain Pablo Neira Ayuso
2016-01-13 10:13 ` [PATCH 1/3 nft] tests/py: don't test log statement from protocol match Florian Westphal
2016-01-13 11:07 ` Pablo Neira Ayuso [this message]
2016-01-13 11:11 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113110753.GD1195@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.