From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 13 Jan 2016 12:21:52 +0000 Subject: [patch] drm/nouveau/pci: reversed condition in nvkm_pcie_set_link() Message-Id: <20160113122152.GC19993@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Airlie , Karol Herbst Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org The condition is reversed so this function is a no-op. Fixes: bcc19d9bf5cd ('drm/nouveau/pci: implement generic code for pcie speed change') Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c index b32954f..d71e5db 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c @@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width) struct pci_bus *pbus; int ret; - if (pci || !pci_is_pcie(pci->pdev)) + if (!pci || !pci_is_pcie(pci->pdev)) return 0; pbus = pci->pdev->bus; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/nouveau/pci: reversed condition in nvkm_pcie_set_link() Date: Wed, 13 Jan 2016 15:21:52 +0300 Message-ID: <20160113122152.GC19993@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C7136E330 for ; Wed, 13 Jan 2016 04:22:08 -0800 (PST) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , Karol Herbst Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhlIGNvbmRpdGlvbiBpcyByZXZlcnNlZCBzbyB0aGlzIGZ1bmN0aW9uIGlzIGEgbm8tb3AuCgpG aXhlczogYmNjMTlkOWJmNWNkICgnZHJtL25vdXZlYXUvcGNpOiBpbXBsZW1lbnQgZ2VuZXJpYyBj b2RlIGZvciBwY2llIHNwZWVkIGNoYW5nZScpClNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIg PGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v bm91dmVhdS9udmttL3N1YmRldi9wY2kvcGNpZS5jIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUv bnZrbS9zdWJkZXYvcGNpL3BjaWUuYwppbmRleCBiMzI5NTRmLi5kNzFlNWRiIDEwMDY0NAotLS0g YS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udmttL3N1YmRldi9wY2kvcGNpZS5jCisrKyBiL2Ry aXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vc3ViZGV2L3BjaS9wY2llLmMKQEAgLTExOSw3ICsx MTksNyBAQCBudmttX3BjaWVfc2V0X2xpbmsoc3RydWN0IG52a21fcGNpICpwY2ksIGVudW0gbnZr bV9wY2llX3NwZWVkIHNwZWVkLCB1OCB3aWR0aCkKIAlzdHJ1Y3QgcGNpX2J1cyAqcGJ1czsKIAlp bnQgcmV0OwogCi0JaWYgKHBjaSB8fCAhcGNpX2lzX3BjaWUocGNpLT5wZGV2KSkKKwlpZiAoIXBj aSB8fCAhcGNpX2lzX3BjaWUocGNpLT5wZGV2KSkKIAkJcmV0dXJuIDA7CiAJcGJ1cyA9IHBjaS0+ cGRldi0+YnVzOwogCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759233AbcAMMWL (ORCPT ); Wed, 13 Jan 2016 07:22:11 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:32594 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754327AbcAMMWJ (ORCPT ); Wed, 13 Jan 2016 07:22:09 -0500 Date: Wed, 13 Jan 2016 15:21:52 +0300 From: Dan Carpenter To: David Airlie , Karol Herbst Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] drm/nouveau/pci: reversed condition in nvkm_pcie_set_link() Message-ID: <20160113122152.GC19993@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The condition is reversed so this function is a no-op. Fixes: bcc19d9bf5cd ('drm/nouveau/pci: implement generic code for pcie speed change') Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c index b32954f..d71e5db 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c @@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width) struct pci_bus *pbus; int ret; - if (pci || !pci_is_pcie(pci->pdev)) + if (!pci || !pci_is_pcie(pci->pdev)) return 0; pbus = pci->pdev->bus;