* [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB
@ 2016-01-13 12:28 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2016-01-13 12:28 UTC (permalink / raw)
To: Jiri Pirko, Elad Raz; +Cc: Ido Schimmel, netdev, linux-kernel, kernel-janitors
There is a missing break statement so we always return -EOPNOTSUPP.
Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
index ffe894e..45479ef 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
@@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev,
case SWITCHDEV_OBJ_ID_PORT_MDB:
err = mlxsw_sp_port_mdb_del(mlxsw_sp_port,
SWITCHDEV_OBJ_PORT_MDB(obj));
+ break;
default:
err = -EOPNOTSUPP;
break;
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB
2016-01-13 12:28 ` Dan Carpenter
(?)
@ 2016-01-13 12:33 ` Elad Raz
-1 siblings, 0 replies; 7+ messages in thread
From: Elad Raz @ 2016-01-13 12:33 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jiri Pirko, Ido Schimmel, netdev, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
> On Jan 13, 2016, at 2:28 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> There is a missing break statement so we always return -EOPNOTSUPP.
>
> Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Elad Raz <eladr@mellanox.com>
>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
> index ffe894e..45479ef 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
> @@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev,
> case SWITCHDEV_OBJ_ID_PORT_MDB:
> err = mlxsw_sp_port_mdb_del(mlxsw_sp_port,
> SWITCHDEV_OBJ_PORT_MDB(obj));
> + break;
> default:
> err = -EOPNOTSUPP;
> break;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB
2016-01-13 12:28 ` Dan Carpenter
@ 2016-01-13 13:38 ` Jiri Pirko
-1 siblings, 0 replies; 7+ messages in thread
From: Jiri Pirko @ 2016-01-13 13:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jiri Pirko, Elad Raz, Ido Schimmel, netdev, linux-kernel,
kernel-janitors
Wed, Jan 13, 2016 at 01:28:23PM CET, dan.carpenter@oracle.com wrote:
>There is a missing break statement so we always return -EOPNOTSUPP.
>
>Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB
@ 2016-01-13 13:38 ` Jiri Pirko
0 siblings, 0 replies; 7+ messages in thread
From: Jiri Pirko @ 2016-01-13 13:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jiri Pirko, Elad Raz, Ido Schimmel, netdev, linux-kernel,
kernel-janitors
Wed, Jan 13, 2016 at 01:28:23PM CET, dan.carpenter@oracle.com wrote:
>There is a missing break statement so we always return -EOPNOTSUPP.
>
>Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB
2016-01-13 12:28 ` Dan Carpenter
@ 2016-01-13 15:35 ` David Miller
-1 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2016-01-13 15:35 UTC (permalink / raw)
To: dan.carpenter; +Cc: jiri, eladr, idosch, netdev, linux-kernel, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 13 Jan 2016 15:28:23 +0300
> There is a missing break statement so we always return -EOPNOTSUPP.
>
> Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB
@ 2016-01-13 15:35 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2016-01-13 15:35 UTC (permalink / raw)
To: dan.carpenter; +Cc: jiri, eladr, idosch, netdev, linux-kernel, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 13 Jan 2016 15:28:23 +0300
> There is a missing break statement so we always return -EOPNOTSUPP.
>
> Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread