From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757975AbcAMTvQ (ORCPT ); Wed, 13 Jan 2016 14:51:16 -0500 Received: from mail.kernel.org ([198.145.29.136]:59377 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755898AbcAMTvI (ORCPT ); Wed, 13 Jan 2016 14:51:08 -0500 Date: Wed, 13 Jan 2016 16:51:03 -0300 From: Arnaldo Carvalho de Melo To: Ben Hutchings Cc: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tools: Fix reading of build-id from vDSO Message-ID: <20160113195103.GQ18367@kernel.org> References: <20160113172301.GT28542@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160113172301.GT28542@decadent.org.uk> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jan 13, 2016 at 05:23:01PM +0000, Ben Hutchings escreveu: > We need to use the long name (the filename) when reading the build-id > from a DSO. Using the short name doesn't work for (at least) vDSOs. Thanks, we should really prefer the long_name, applied. - Arnaldo > Signed-off-by: Ben Hutchings > --- > tools/perf/util/symbol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c > index cd08027..b60bc49 100644 > --- a/tools/perf/util/symbol.c > +++ b/tools/perf/util/symbol.c > @@ -1465,7 +1465,7 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter) > * Read the build id if possible. This is required for > * DSO_BINARY_TYPE__BUILDID_DEBUGINFO to work > */ > - if (filename__read_build_id(dso->name, build_id, BUILD_ID_SIZE) > 0) > + if (filename__read_build_id(dso->long_name, build_id, BUILD_ID_SIZE) > 0) > dso__set_build_id(dso, build_id); > > /*