From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292AbcAMXg4 (ORCPT ); Wed, 13 Jan 2016 18:36:56 -0500 Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:33560 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752847AbcAMXgg (ORCPT ); Wed, 13 Jan 2016 18:36:36 -0500 Date: Thu, 14 Jan 2016 00:36:28 +0100 From: Florian Westphal To: David Miller Cc: koct9i@gmail.com, netdev@vger.kernel.org, dev@openvswitch.org, cascardo@redhat.com, edumazet@google.com, fw@strlen.de, linux-kernel@vger.kernel.org, pshelar@nicira.com, xiyou.wangcong@gmail.com Subject: Re: [PATCH v2] net: preserve IP control block during GSO segmentation Message-ID: <20160113233628.GA10507@breakpoint.cc> References: <145225570625.30903.13936642758071448458.stgit@zurg> <20160113.155112.119405358547782630.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160113.155112.119405358547782630.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller wrote: > From: Konstantin Khlebnikov > Date: Fri, 08 Jan 2016 15:21:46 +0300 > > > Skb_gso_segment() uses skb control block during segmentation. > > This patch adds 32-bytes room for previous control block which > > will be copied into all resulting segments. > > > > This patch fixes kernel crash during fragmenting forwarded packets. > > Fragmentation requires valid IP CB in skb for clearing ip options. > > Also patch removes custom save/restore in ovs code, now it's redundant. > > > > Signed-off-by: Konstantin Khlebnikov > > Link: http://lkml.kernel.org/r/CALYGNiP-0MZ-FExV2HutTvE9U-QQtkKSoE--KN=JQE5STYsjAA@mail.gmail.com > > If this works I definitely prefer this approach to the other patch > where the CB is copied back and forth. I quite frankly don't care and just like you to apply one or the other; use coin toss if needed :-} I would prefer to use a on-stack state since there is no need to use skb->cb (no queueing) but when I gave it a try it got out of hand rather quick :-/ Anyway Konstantins approach is safe since we only need this in ovs/ip forward + nfnetlink_queue cases and in all of these there is enough room at the cb end (for now at least). From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: [PATCH v2] net: preserve IP control block during GSO segmentation Date: Thu, 14 Jan 2016 00:36:28 +0100 Message-ID: <20160113233628.GA10507@breakpoint.cc> References: <145225570625.30903.13936642758071448458.stgit@zurg> <20160113.155112.119405358547782630.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, koct9i-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org To: David Miller Return-path: Content-Disposition: inline In-Reply-To: <20160113.155112.119405358547782630.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" List-Id: netdev.vger.kernel.org RGF2aWQgTWlsbGVyIDxkYXZlbUBkYXZlbWxvZnQubmV0PiB3cm90ZToKPiBGcm9tOiBLb25zdGFu dGluIEtobGVibmlrb3YgPGtvY3Q5aUBnbWFpbC5jb20+Cj4gRGF0ZTogRnJpLCAwOCBKYW4gMjAx NiAxNToyMTo0NiArMDMwMAo+IAo+ID4gU2tiX2dzb19zZWdtZW50KCkgdXNlcyBza2IgY29udHJv bCBibG9jayBkdXJpbmcgc2VnbWVudGF0aW9uLgo+ID4gVGhpcyBwYXRjaCBhZGRzIDMyLWJ5dGVz IHJvb20gZm9yIHByZXZpb3VzIGNvbnRyb2wgYmxvY2sgd2hpY2gKPiA+IHdpbGwgYmUgY29waWVk IGludG8gYWxsIHJlc3VsdGluZyBzZWdtZW50cy4KPiA+IAo+ID4gVGhpcyBwYXRjaCBmaXhlcyBr ZXJuZWwgY3Jhc2ggZHVyaW5nIGZyYWdtZW50aW5nIGZvcndhcmRlZCBwYWNrZXRzLgo+ID4gRnJh Z21lbnRhdGlvbiByZXF1aXJlcyB2YWxpZCBJUCBDQiBpbiBza2IgZm9yIGNsZWFyaW5nIGlwIG9w dGlvbnMuCj4gPiBBbHNvIHBhdGNoIHJlbW92ZXMgY3VzdG9tIHNhdmUvcmVzdG9yZSBpbiBvdnMg Y29kZSwgbm93IGl0J3MgcmVkdW5kYW50Lgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBLb25zdGFu dGluIEtobGVibmlrb3YgPGtvY3Q5aUBnbWFpbC5jb20+Cj4gPiBMaW5rOiBodHRwOi8vbGttbC5r ZXJuZWwub3JnL3IvQ0FMWUdOaVAtME1aLUZFeFYySHV0VHZFOVUtUVF0a0tTb0UtLUtOPUpRRTVT VFlzakFBQG1haWwuZ21haWwuY29tCj4gCj4gSWYgdGhpcyB3b3JrcyBJIGRlZmluaXRlbHkgcHJl ZmVyIHRoaXMgYXBwcm9hY2ggdG8gdGhlIG90aGVyIHBhdGNoCj4gd2hlcmUgdGhlIENCIGlzIGNv cGllZCBiYWNrIGFuZCBmb3J0aC4KCkkgcXVpdGUgZnJhbmtseSBkb24ndCBjYXJlIGFuZCBqdXN0 IGxpa2UgeW91IHRvIGFwcGx5IG9uZSBvciB0aGUgb3RoZXI7CnVzZSBjb2luIHRvc3MgaWYgbmVl ZGVkIDotfQoKSSB3b3VsZCBwcmVmZXIgdG8gdXNlIGEgb24tc3RhY2sgc3RhdGUgc2luY2UgdGhl cmUgaXMgbm8gbmVlZCB0bwp1c2Ugc2tiLT5jYiAobm8gcXVldWVpbmcpIGJ1dCB3aGVuIEkgZ2F2 ZSBpdCBhIHRyeSBpdCBnb3Qgb3V0IG9mIGhhbmQKcmF0aGVyIHF1aWNrIDotLwoKQW55d2F5IEtv bnN0YW50aW5zIGFwcHJvYWNoIGlzIHNhZmUgc2luY2Ugd2Ugb25seSBuZWVkIHRoaXMgaW4Kb3Zz L2lwIGZvcndhcmQgKyBuZm5ldGxpbmtfcXVldWUgY2FzZXMgYW5kIGluIGFsbCBvZiB0aGVzZSB0 aGVyZSBpcwplbm91Z2ggcm9vbSBhdCB0aGUgY2IgZW5kIChmb3Igbm93IGF0IGxlYXN0KS4KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2IG1haWxpbmcg bGlzdApkZXZAb3BlbnZzd2l0Y2gub3JnCmh0dHA6Ly9vcGVudnN3aXRjaC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kZXYK