From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJjAz-0000cJ-Gl for qemu-devel@nongnu.org; Thu, 14 Jan 2016 09:47:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJjAw-0004fk-9p for qemu-devel@nongnu.org; Thu, 14 Jan 2016 09:47:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJjAw-0004fe-4k for qemu-devel@nongnu.org; Thu, 14 Jan 2016 09:46:58 -0500 Date: Thu, 14 Jan 2016 14:46:53 +0000 From: "Daniel P. Berrange" Message-ID: <20160114144653.GW910@redhat.com> References: <1452081699-11894-1-git-send-email-den@openvz.org> <5697AF2F.80404@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5697AF2F.80404@openvz.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/2] qga: guest-set-user-password - added ability to create new user Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Yuri Pudgorodskiy , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , QEMU , Michael Roth On Thu, Jan 14, 2016 at 05:22:39PM +0300, Denis V. Lunev wrote: > On 01/14/2016 05:18 PM, Marc-Andr=C3=A9 Lureau wrote: > >Hi > > > >On Wed, Jan 6, 2016 at 1:01 PM, Denis V. Lunev wrote: > >>These patches add optional 'create' flag to guest-set-user-password c= ommand. > >>When it is specified, a new user will be created if it does not > >>exist yet. > >> > >What's the motivation to re-use set-password instead of a new command? >=20 > because we will have to change the password later on after addition > of such user. Also this looks better for a case "create if not exists" = and > force new password. I don't think that's very compelling honestly. In addition when creating user accounts there's a whole bunch more parameters you potentially want to set besides just the username - see how many options exist with the 'useradd' command. Also with some users you might not want to set any password. So if we want to create users via QGA, I think that having a separate command makes more sense. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|