From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v1 1/2] lib/string_helpers: export string_units_{2,10} for others Date: Thu, 14 Jan 2016 15:44:06 +0000 Message-ID: <20160114154406.GC3602@codeblueprint.co.uk> References: <1452604386-13673-1-git-send-email-andriy.shevchenko@linux.intel.com> <1452764705.2521.29.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1452764705.2521.29.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Shevchenko Cc: Robert Elliott , Andrew Morton , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-efi@vger.kernel.org On Thu, 14 Jan, at 11:45:05AM, Andy Shevchenko wrote: > On Tue, 2016-01-12 at 15:13 +0200, Andy Shevchenko wrote: > > There is one user coming which would like to use those string arrays. > > It might > > be useful for any other user in the future. > > Please, comment on the idea, but discard both patches, I'm cooking > better approach. I like this idea. I'm all for reusing existing code where possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754342AbcANPoS (ORCPT ); Thu, 14 Jan 2016 10:44:18 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:35621 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752455AbcANPoQ (ORCPT ); Thu, 14 Jan 2016 10:44:16 -0500 Date: Thu, 14 Jan 2016 15:44:06 +0000 From: Matt Fleming To: Andy Shevchenko Cc: Robert Elliott , Andrew Morton , linux-efi@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] lib/string_helpers: export string_units_{2,10} for others Message-ID: <20160114154406.GC3602@codeblueprint.co.uk> References: <1452604386-13673-1-git-send-email-andriy.shevchenko@linux.intel.com> <1452764705.2521.29.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452764705.2521.29.camel@linux.intel.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jan, at 11:45:05AM, Andy Shevchenko wrote: > On Tue, 2016-01-12 at 15:13 +0200, Andy Shevchenko wrote: > > There is one user coming which would like to use those string arrays. > > It might > > be useful for any other user in the future. > > Please, comment on the idea, but discard both patches, I'm cooking > better approach. I like this idea. I'm all for reusing existing code where possible.