From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/3] mtd: nand: remove EXPORT_SYMBOL of nand_scan_bbt()
Date: Thu, 14 Jan 2016 16:17:00 +0100 [thread overview]
Message-ID: <20160114161700.477715cb@bbrezillon> (raw)
In-Reply-To: <1452782691-5193-1-git-send-email-thomas.petazzoni@free-electrons.com>
Hi Thomas,
On Thu, 14 Jan 2016 15:44:49 +0100
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Since commit 17799359e7b3fa6ef4f2bf926cd6821cf7903ecf ("mtd: nand_bbt:
> make nand_scan_bbt() static"), the nand_scan_bbt() function is marked
> as static but is still exported using EXPORT_SYMBOL(), which doesn't
> make much sense.
>
> This commit gets rid of the useless EXPORT_SYMBOL.
Hehe, I noticed this useless EXPORT_SYMBOL while reviewing the BBT
rework, just forgot to post the patch removing it.
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Thanks,
Boris
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> drivers/mtd/nand/nand_bbt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
> index b1d4f81..4dfaf93 100644
> --- a/drivers/mtd/nand/nand_bbt.c
> +++ b/drivers/mtd/nand/nand_bbt.c
> @@ -1373,5 +1373,3 @@ int nand_markbad_bbt(struct mtd_info *mtd, loff_t offs)
>
> return ret;
> }
> -
> -EXPORT_SYMBOL(nand_scan_bbt);
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-14 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 14:44 [PATCH 1/3] mtd: nand: remove EXPORT_SYMBOL of nand_scan_bbt() Thomas Petazzoni
2016-01-14 14:44 ` [PATCH 2/3] mtd: onenand: make onenand_scan_bbt() static Thomas Petazzoni
2016-01-14 15:56 ` Boris Brezillon
2016-01-14 14:44 ` [PATCH 3/3] mtd: onenand: unexport onenand_default_bbt() Thomas Petazzoni
2016-01-14 15:56 ` Boris Brezillon
2016-01-14 15:17 ` Boris Brezillon [this message]
2016-01-23 22:01 ` [PATCH 1/3] mtd: nand: remove EXPORT_SYMBOL of nand_scan_bbt() Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114161700.477715cb@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mtd@lists.infradead.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.