From: Olof Johansson <olof.johansson@axis.com>
To: Andre McCurdy <armccurdy@gmail.com>,
Richard Purdie <richard.purdie@linuxfoundation.org>,
bitbake-devel <bitbake-devel@lists.openembedded.org>
Cc: pkj@axis.com
Subject: Re: [PATCH] fetch/git: Change to use clearer ssh url syntax for broken servers
Date: Thu, 14 Jan 2016 18:07:52 +0100 [thread overview]
Message-ID: <20160114170752.GH31212@axis.com> (raw)
In-Reply-To: <CAJ86T=X9LU04NhjnaLtq+G7WSE6=9t2yiNF2MiuDrnn+M5exLQ@mail.gmail.com>
On 16-01-14 08:51 -0800, Andre McCurdy wrote:
> > I'm not sure there is one other than special casing bitbucket urls in
> > the fetcher.
>
> But I don't think there is any problem with BitBucket. The original
> bug report was caused by trying to use a URL with a ':' between the
> host and the repo path. A URL like that does not work when prefixed by
> ssh://, it's the same for GitHub URLs too.
Indeed, the reported URL is not an RFC 3986 comformant URI. While
ssh://example.com:/username/project.git
would be a kind of valid URI (the RFC doesn't forbid having an
empty port, see section 3.2.3), not having a path delimiter at
all however is not allowed. And fixing this by breaking RFC
comformant use cases is very suprising to me.
--
olofjn
next prev parent reply other threads:[~2016-01-14 17:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 13:18 [PATCH] fetch/git: Change to use clearer ssh url syntax for broken servers Richard Purdie
2016-01-13 21:37 ` Andre McCurdy
2016-01-13 22:19 ` Richard Purdie
2016-01-13 23:20 ` Andre McCurdy
2016-01-13 23:59 ` Andre McCurdy
2016-01-14 14:47 ` Peter Kjellerstedt
2016-01-14 15:25 ` Richard Purdie
2016-01-14 16:51 ` Andre McCurdy
2016-01-14 17:07 ` Olof Johansson [this message]
2016-01-14 17:50 ` Peter Kjellerstedt
2016-01-15 15:04 ` Richard Purdie
2016-01-15 16:18 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114170752.GH31212@axis.com \
--to=olof.johansson@axis.com \
--cc=armccurdy@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=pkj@axis.com \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.