From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 14 Jan 2016 12:56:42 -0500 Subject: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined In-Reply-To: References: <1449715741-43463-1-git-send-email-dongsheng.wang@nxp.com> <20151210122538.GS667@bill-the-cat> <20151211122947.GU667@bill-the-cat> <20160104155016.GE4093@bill-the-cat> Message-ID: <20160114175642.GG3359@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jan 11, 2016 at 02:51:39AM +0000, Dongsheng Wang wrote: > Hi Tom, > > Sorry for my late reply, and thanks for your reply. > > How about the following comments, following your suggestion I remove some redundant comments? > > If my understanding is wrong, please correct me, thanks: > #if defined(CONFIG_ARMV7_SECURE_BASE) && defined(CONFIG_ARMV7_NONSEC) > /* > * If CONFIG_ARMV7_SECURE_BASE is true, secure code will not > * bundle with u-boot, and codes offset are fixed. Secure zone code offsets > * only needs to be copied from loading address to from the loading address > * CONFIG_ARMV7_SECURE_BASE, which is the linking and running > * address for secure code. > * > * If undefine CONFIG_ARMV7_SECURE_BASE secure zone will be If CONFIG_ARMV7_SECURE_BASE is undefined, the secure zone will be > * included in u-boot space, and some absolute address were used u-boot address space > * in secure code. Accompanied by u-boot relocation secure code > * also need to relocate the absolute address. in secure code. The absolute addresses of the secure code also needs to be relocated along with the accompanying u-boot code. > * > * So DISCARD is only for CONFIG_ARMV7_SECURE_BASE. > */ > /DISCARD/ : { *(.rel._secure*) } > #endif Otherwise looks good, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: